Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Show Tab Bar from the View menu on mac #1134

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
2 participants
@scribblemaniac
Copy link
Member

scribblemaniac commented Dec 4, 2018

Newer versions of macOS add a "Show Tab Bar" option to the "View" menu automatically. Pressing it screws with the layout a little bit like this:
double_titlebar
There is no way to remove the menu item with Qt, see this bug report. To fix this I integrated a small amount of native objective-c code for mac builds.

This also enables us to easily add support for more native mac features in the future. I implemented mouse coalescing in this same way, but is currently not being used. It seems like what we are currently doing for setting mouse coalescing is not working, so when we actually disable it the brush stroke lags significantly similar to #1133. According to my event counter the peak number of events doubles from 128 to 256. This shouldn't cause a noticeable slowdown because we can process that many tablet events just fine. I've spent a few hours trying to debug this but am unsure exactly what the underlying problem is. I think it goes deeper than were just processing the events too slowly though. For now, we can just leave mouse coalescing enabled.

Remove Show Tab Bar from the View menu on mac
This was done by integrating a small amount of native objective-c
code for mac since Qt has no way to do this at the moment.

This also enables us to easily add support for more native mac
features in the future. Mouse coalescing has been implemented
in this same way, but is not currently being used. See PR for
details.

@chchwy chchwy added this to the 0.6.3 milestone Dec 4, 2018

@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Dec 4, 2018

Thanks, @scribblemaniac

@chchwy chchwy merged commit 368a9f1 into pencil2d:master Dec 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.