Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve darkmode QDockWidget titlebar #1137

Merged
merged 4 commits into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@CandyFace
Copy link
Member

CandyFace commented Dec 11, 2018

This improves the look of QDockWidget titlebar on mac OS with Mojave Dark mode, making it look much closer to native...
Before:
image2

After:
image

Having looked at Qt bug report, Darkmode appearance still seems to be WIP, so there's bound to be bugs, especially since it's still a very recent addition...

I've already reported one: https://bugreports.qt.io/browse/QTBUG-72486
which explains why the qlabels in the timeline are dark when they should be light.

CandyFace added some commits Dec 11, 2018

@scribblemaniac
Copy link
Member

scribblemaniac left a comment

I'm going to have to take you word that this matches the native display. It definitely looks better. See my other comments for requested changes.

Show resolved Hide resolved core_lib/src/external/platformhandler.h
Show resolved Hide resolved core_lib/src/interface/basedockwidget.cpp Outdated

@CandyFace CandyFace force-pushed the CandyFace:improve_darkmode branch from d724e56 to d53ced3 Dec 11, 2018

Use preprocessor to check for Mojave...
aaand forgot to remove gradient reference.

@CandyFace CandyFace force-pushed the CandyFace:improve_darkmode branch from d53ced3 to d615752 Dec 11, 2018

@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Dec 12, 2018

Thanks @CandyFace

@chchwy chchwy merged commit 7f36696 into pencil2d:master Dec 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chchwy chchwy added this to the 0.6.3 milestone Dec 12, 2018

@CandyFace CandyFace deleted the CandyFace:improve_darkmode branch Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.