Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio volume in movie export #1139

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@scribblemaniac
Copy link
Member

scribblemaniac commented Dec 13, 2018

Fixes the issue with sounds starting off quiet and progressively getting louder. There's a small possibility it will fix the no-sound issue too.

Fixes #1138

Fix audio volume in movie export
Amix has an automatic dropout that adjusts the volume to 1/n,
where n is the number of sounds currently playing. This isn't
necessarily a bad thing to do, but it doesn't work for us because
adelay pads the beginning with silence rather than offsetting the
clip. Also I don't think qt does this so we should try and make
it sound consistent with the preview playback. The fix is to
use amerge + pan instead.

@scribblemaniac scribblemaniac added this to the 0.6.3 milestone Dec 13, 2018

@chchwy chchwy merged commit 74fdcbf into pencil2d:master Dec 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.