Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved warnings for NULL and old-casts #1141

Merged
merged 1 commit into from Dec 16, 2018

Conversation

Projects
None yet
2 participants
@davidlamhauge
Copy link
Contributor

davidlamhauge commented Dec 14, 2018

This PR resolved many of the warnings in the Interface folder, in core_lib.
Some warnings remain. In scribblearea.cpp alone there are 59 warnings concerning 'implicit conversions'. Someone should look at this one day. I'm not sure it's within my reach to decide whether Penci2D should use floats, doubles, qreals or what...

@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Dec 16, 2018

Thanks @davidlamhauge
In most cases, float is the go-to type unless higher precession is required.

@chchwy chchwy merged commit a420d62 into pencil2d:master Dec 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chchwy chchwy added this to the 0.6.3 milestone Dec 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.