Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force light theme on mac os #1142

Merged
merged 1 commit into from Dec 15, 2018

Conversation

Projects
None yet
2 participants
@CandyFace
Copy link
Member

CandyFace commented Dec 15, 2018

This change comes from a discussion on Discord:
the story is that this commit d615752
tried to fix some styling regarding Mojave dark mode. What I failed to see however is that the flag apparently already exists from Mac OS 10.13 and thus will throw this error if compiled on that target

'NSAppearanceNameDarkAqua' is only available on macOS 10_14 or newer [-Wunguarded-availability-new]
return apperance.name == NSAppearanceNameDarkAqua;
^~~~~~

Thus my conclusion is that since there's no reliable way to determine whether the OS runs AquaDark aka. dark mode, and that it still has various layout bugs regarding it, we should force the standard light theme for now to make the experience as pleasant as possible.

it's still possible to change to dark mode by setting the parameter through info.plist though so if you still want it, it can be enabled again.

Force light theme on mac os
Qt is not ready for Mojave dark mode yet and since there's no reliable way to determine whether the OS runs AquaDark, we'll force the standard light theme for now.
@chchwy

This comment has been minimized.

Copy link
Member

chchwy commented Dec 15, 2018

Thank @CandyFace

@chchwy chchwy merged commit 441e646 into pencil2d:master Dec 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.