Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Renable dark mode on macOS #1144
it works on Mac OS 10.14 but what about the build server which runs on 10.12?
although that's just a warning, I think we should have it verified on a machine that actually runs 10.12 to make sure it works.
The MAC_OS_X_VERSION_10_14 define is not enough by itself, since it already exists in 10.13 SDK. It would have to be something like the define this commit adds.
Given that Scribble added a string to contain the value though, it'll probably work either way now.