Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSSL .dlls to enable https requests #1216

Merged
merged 1 commit into from May 11, 2019

Conversation

scribblemaniac
Copy link
Member

@scribblemaniac scribblemaniac commented May 2, 2019

I have tested the 64-bit binaries from https://indy.fulgan.com/SSL/ with v0.6.3 of Pencil2D and this fixes the Updater error on Windows 10.

Fixes #1195

@Jose-Moreno
Copy link
Member

This also fixes the issues reported under Windows 7 🎉

@scribblemaniac scribblemaniac added this to the 0.6.4 milestone May 2, 2019
Copy link
Member

@MrStevns MrStevns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

My only comment is regarding local compilation. We should consider having the binaries somewhere or it should be mentioned on the wiki that it is required on Windows.

@scribblemaniac
Copy link
Member Author

@candyface I'll update the compilation guide on the wiki and docs/build_win.md. Although now that I look at them, we are also missing the instructions installing the ffmpeg plugin from all build instructions.

@scribblemaniac
Copy link
Member Author

I will merge this now and make a new issue to update the documentation later so that we can get this update out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update checker fails to probe current version (0.6.3) and displays an error message
3 participants