Fix translate bug. Fix a warning #1240
Conversation
|
Thanks @chrisju |
| } | ||
| break; |
There was a problem hiding this comment.
No no no, this was right before. We intentionally want to create a new key in the duplicate mode if no previous key exists so it's as if it is duplicating the empty frames. Hence why there there are comments directly below this explaining that we want to fall through if the previous keyframe does not exist. @chchwy Please revert this.
There was a problem hiding this comment.
If we move the comments to right below the close bracket on line 909 and add a space to "fallthrough", it apparently will remove the warning on GCC. See https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough. Wouldn't be a bad idea to do this.
| @@ -1827,7 +1827,7 @@ | |||
| <message> | |||
| <location filename="../app/ui/mainwindow2.ui" line="886"/> | |||
| <source>Move Frame Backward</source> | |||
| <translation>先后移动帧</translation> | |||
| <translation>向后移动帧</translation> | |||
There was a problem hiding this comment.
Does changing the ts files work or does this need to be changed on Transifex? I was under the impression that it needed be changed on Transifex or it will just be overwritten next time the translations are pulled, but I am not fully familiar with that process.
There was a problem hiding this comment.
I need to upload this CN.ts file to transifex otherwise it will be overwritten next time as you said.
I will do that.
|
@chrisju Thanks for your contributions. While our code does produce a warning where you change the code, the placement of the break was intentional to have a certain behaviour. We will look into other options to remove the warning. In case you are not aware, we use the Transifex translation platform to make it easier for people to translate and proofread our application. You can find our project here: https://www.transifex.com/pencil2d/pencil2d/ and apply for the Chinese team if you are interested in contributing further to the translations. We are grateful for any help you can provide. |
fix 2 chinese translation errors