Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave & Grid preference settings adjustment #1249

Merged
merged 1 commit into from Aug 21, 2019

Conversation

Jose-Moreno
Copy link
Member

@Jose-Moreno Jose-Moreno commented Aug 20, 2019

  • Autosave max. value set to 8192 in filespage.ui
  • Autosave initial value set to 256 in preferencemanager.cpp (this will provide an average of about 5~7 minutes of uninterrupted drawing before the autosave alert kicks in)
  • Grid W & Grid H minimum values set to 1px in generalpage.ui

If there's a mistake or a missing alteration that needs to be made please point it out descriptively as usual. Thanks ☺️

- Autosave max. value set to 8192 in filespage.ui
- Atuosave initial value set to 256 in preferencemanager.cpp
- Grid W & Grid H minimum values set to 1 in generalpage.ui
@MrStevns
Copy link
Member

MrStevns commented Aug 21, 2019

I assume this is a quick fix to delay never be bothered by the autosave popup ;) Seems fine to me though we really should reconsider the behaviour of that one.

Copy link
Member

@scribblemaniac scribblemaniac left a comment

Tested and everything looks good. This PR is small enough to merge with just one review, but I want to wait and hear if any of the @pencil2d/developers have thoughts on the particular values chosen. I think they are all reasonable.

@MrStevns MrStevns merged commit a3669d9 into pencil2d:master Aug 21, 2019
@Jose-Moreno Jose-Moreno deleted the autosave-preferences branch Aug 23, 2019
@Jose-Moreno
Copy link
Member Author

Jose-Moreno commented Aug 23, 2019

Thanks guys 😄

@chchwy chchwy added this to the 0.6.5 milestone Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants