Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all spin boxes maintaining focus after returning #1253

Merged
merged 1 commit into from Aug 24, 2019

Conversation

scribblemaniac
Copy link
Member

@scribblemaniac scribblemaniac commented Aug 22, 2019

Created a helper function to connect the signal that spin boxes emit when enter is pressed to a function that removes their focus. Should allow all keyboard shortcuts to work after pressing typing in any of the spin boxes and pressing enter.

Fixes #1230

@scribblemaniac scribblemaniac added Bug UX Related to the way users interact with the program labels Aug 22, 2019
Copy link
Member

@MrStevns MrStevns left a comment

Tested and confirmed that issue has been fixed.

@chchwy
Copy link
Member

chchwy commented Aug 23, 2019

A quick question. After removing the focus, users should not be able to enter another value until they click on spinbox again, right?

@scribblemaniac
Copy link
Member Author

scribblemaniac commented Aug 23, 2019

Correct. The numbers they enter could themselves be shortcuts.

@MrStevns MrStevns merged commit 05ab92e into pencil2d:bugfixes Aug 24, 2019
@scribblemaniac scribblemaniac deleted the spin-box-fix branch Aug 24, 2019
@chchwy chchwy added this to the 0.6.5 milestone Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug UX Related to the way users interact with the program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants