#1105 Added checks on timelinecells, so scrub is tracked #1257
Conversation
|
Since the number of changes here are small, we can merge this right away, however to give the chance of someone else to review it, I'll wait till tomorrow before merging. |
|
It is indeed small changes, but let it rest a day if someone else wants to review it. Thanks! |
|
Awesome work David, once this is merged Github will automatically close the relevant issue. Thanks! This closes #1105 |
scribblemaniac
added
Enhancement
Timeline
UX
There was a problem hiding this comment.
I personally think that the timeline should move for any scrubbing actions, not just playback. For instance, if you are moving it with the arrows keys or mouse, you want to see where you are moving it to, even if that's off the current screen. I've submitted a PR to your repo for this, but I'd like to hear if there are any thought on this idea first. Otherwise this looks good.
|
I agree that would be useful. |
…king Update timeline position for all scrub movements, not just playback
|
I also agree that should be helpful since currently using the arrow keys or the period / comma keys do not update the timeline. It'd be nice that probably the Next / previous keyframe actions update the timeline as well. 👌 |
|
Two small errors fixed. |
There was a problem hiding this comment.
Reviewing after latest code changes: looks fine to me.
A question though, right now the behaviour differs between going forward and backwards, going backwards only pushes the timeline a frame at a time, while going forward pushes you x frames forward... I think this should be consistent but which behaviour is best? the former gives you absolute control of the situation, while the latter throws you x frames forward, so if you wanted to only scrub 3 frames or so, then you'll be required to scrub forwards afterwards.
I'd also like to see the scrubber being paused temporarily while moving the timeline scrollbar or at least allow free roaming. Right now you're fixed to the scrubber visibility wise.
|
I have made so it behave likewise forwards and backwards. |
There was a problem hiding this comment.
Looks good. I like that it still jumps halfway during playback rather than staying at the end as it means less full timeline updates during the time-sensitive playback. I might even be tempted to go a step further and have it jump to the beginning when the scrubber goes off the screen during playback (ie mFrameOffset = mEditor->currentFrame())
|
It is less timeline updates, that's the reason for jumping halfway back, when it goes of screen. I thought that it would be too much if it went all the way over to the left. |
|
@candyface Do you have any comments on the discussion about how far back the scrubber should go during playback? |
Not really, I think it's fine to scrub to the middle of the view. |
|
Two developers has approved the changes, so I'm merging. If there's a need to further discuss the functionality, a new issue can be created. |
This PR see to it, that the scrubber always is visible during playback.
It is a rather simple solution, since we shouldn't do too complicated things on the timeline, while we wait for the Timeline rewrite.
This one has bugged me (and @Jose-Moreno) and possible others for some time, so here is a solution.