-
Notifications
You must be signed in to change notification settings - Fork 286
#1174 More consistent palette import behavior #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1174 More consistent palette import behavior #1262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the export UI should be simplified, the functionality itself looks fine.
Let's keep it at only one export palette action and let the user decide which extension they want to use.
I have merged the newest Master branch into this branch, and fixed the typs. |
Now, there is always an extension. |
Simplify palette formats
It again saves without file extension in Linux (Ubuntu 18.04). |
The save without extension on linux should be fixed via #1299 The issue you mention stems from gtk3 not respecting its filter selector, so if no extension is given, then the file will be saved with no extension. |
I'd say this is ready to be reviewed again whenever the remaining conflicts has been fixed. |
Conflicts has been fixed. |
core_lib/src/util/fileformat.h
Outdated
@@ -63,6 +63,8 @@ GNU General Public License for more details. | |||
#define PFF_DEFAULT_PALETTE_EXT \ | |||
QString(".xml") | |||
|
|||
#define PFF_PALETTE_EXT_FILTER \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This macro should be removed, It's redundant since it is defined above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @davidlamhauge 👍
This PR addresses the inconsistent behavior on opening, importing, saving and exporting palettes.
As we agreed, this is how it goes:
I hope I've covered all (or most) issues we've talked about.
This closes Inconsistent palette import behavior #1174