Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous enhancements #1268

Merged
merged 4 commits into from Sep 28, 2019
Merged

Conversation

scribblemaniac
Copy link
Member

@scribblemaniac scribblemaniac commented Sep 21, 2019

Here is a series of small enhancements (or bug fixes that need to be done on master). The commit messages should be fairly self-explanatory.

Special thanks to @candyface for bringing to my attention some ways of improving the flood fill speed.

The scanLine functions and compareColor functions are excellent
candidates for inlining as they are small and called often. For
some reasons the compiler does not want to do this automatically.
@scribblemaniac scribblemaniac added Enhancement 🔹 Minor PR (only one reviewer required) labels Sep 21, 2019
@scribblemaniac scribblemaniac added this to the 0.6.5 milestone Sep 21, 2019
Copy link
Member

@MrStevns MrStevns left a comment

LGTM.

Tested smudge and it's definitely better on transparent layer now.. it's still terribly broken though but that's another problem to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🔹 Minor PR (only one reviewer required)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants