Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous bugfixes #1269

Merged
merged 11 commits into from Nov 10, 2019
Merged

Conversation

scribblemaniac
Copy link
Member

@scribblemaniac scribblemaniac commented Sep 21, 2019

Here are a bunch of bugfixes, almost all for unreported bugs. The commit messages describe what each of the changes are for, feel free to ask for clarification on any of them if needed. I recommend reviewing commit-by-commit as it will make much more sense than looking at all of the changes at once.

scribblemaniac added 10 commits Sep 2, 2019
Improves tab ordering for the:
- Display widget
- Image sequence and movie export dialogs
- Toolbox widget
The mouse generates pointer events regardless of the current layer
so I don't see why the tablet shouldn't do the same.
Also did some refactoring of the notifyAnimationLengthChanged
calls so that they are called for all ways of creating a frame.
The Q_ASSERT being triggered was in LayerManager::currentLayer(int)
and was being triggered because the timeline was trying to update
with the currentLayerIndex in Editor not yet updated yet, and
potentially out of range.

Also fixed the debug details of LayerSound::saveKeyFrameFile
not being returned to the caller.
When two frames have partly the same contents, but different
dimensions, there can sometimes be "jitter" effect when zoomed
out. This reduces that jitter dramatically, although there is
still about a one pixel offset sometimes.

Special thanks to Burn for reporting.
These changes fix a few bugs with mouse and tablet inputs,
including:
- Program was left in inconsisent state (mMouseInUse=true but
mouse is not actually in use) when trying to draw on a hidden
layer with a mouse.
- After fixing the previous bug, when trying to draw on a hidden
layer with a tablet, the message would come up, but then it would
draw on the hidden layer anyway.
- Many actions which are rightfully blocked when drawing with a
mouse were allowed when drawing with the tablet (ex. zooming with
mouse wheel or using shortcuts)
@scribblemaniac scribblemaniac added 🔹 Minor PR (only one reviewer required) Bug labels Sep 21, 2019
@scribblemaniac scribblemaniac added this to the 0.6.5 milestone Sep 21, 2019
Copy link
Member

@MrStevns MrStevns left a comment

Looks good to me aside from my discovery with the camera border... I'm quite certain the behaviour is wrong now and therefore requires to be change before merged.

Now sure what the commit entails either as the border has always rotated with the view, could you please elaborate on this @scribblemaniac ?

core_lib/src/canvaspainter.cpp Show resolved Hide resolved
Copy link
Member

@MrStevns MrStevns left a comment

I've reviewed the code again and the issue I've mentioned previously has been fixed. Now I only have one comment left.. should we implicitly move to an available keyframe with sound keyframes?

I know Jose has mentioned that it's annoying that the scrubber moves on its own when creating a new keyframe, so maybe that's not a good idea?

@MrStevns MrStevns merged commit f9260ea into pencil2d:bugfixes Nov 10, 2019
@scribblemaniac scribblemaniac deleted the misc-bugfixes branch Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🔹 Minor PR (only one reviewer required)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants