Miscellaneous bugfixes #1269
Merged
Miscellaneous bugfixes #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves tab ordering for the: - Display widget - Image sequence and movie export dialogs - Toolbox widget
The mouse generates pointer events regardless of the current layer so I don't see why the tablet shouldn't do the same.
Also did some refactoring of the notifyAnimationLengthChanged calls so that they are called for all ways of creating a frame.
The Q_ASSERT being triggered was in LayerManager::currentLayer(int) and was being triggered because the timeline was trying to update with the currentLayerIndex in Editor not yet updated yet, and potentially out of range. Also fixed the debug details of LayerSound::saveKeyFrameFile not being returned to the caller.
When two frames have partly the same contents, but different dimensions, there can sometimes be "jitter" effect when zoomed out. This reduces that jitter dramatically, although there is still about a one pixel offset sometimes. Special thanks to Burn for reporting.
These changes fix a few bugs with mouse and tablet inputs, including: - Program was left in inconsisent state (mMouseInUse=true but mouse is not actually in use) when trying to draw on a hidden layer with a mouse. - After fixing the previous bug, when trying to draw on a hidden layer with a tablet, the message would come up, but then it would draw on the hidden layer anyway. - Many actions which are rightfully blocked when drawing with a mouse were allowed when drawing with the tablet (ex. zooming with mouse wheel or using shortcuts)
Merged
MrStevns
requested changes
Sep 28, 2019
There was a problem hiding this comment.
Looks good to me aside from my discovery with the camera border... I'm quite certain the behaviour is wrong now and therefore requires to be change before merged.
Now sure what the commit entails either as the border has always rotated with the view, could you please elaborate on this @scribblemaniac ?
MrStevns
reviewed
Nov 10, 2019
MrStevns
approved these changes
Nov 10, 2019
There was a problem hiding this comment.
I've reviewed the code again and the issue I've mentioned previously has been fixed. Now I only have one comment left.. should we implicitly move to an available keyframe with sound keyframes?
I know Jose has mentioned that it's annoying that the scrubber moves on its own when creating a new keyframe, so maybe that's not a good idea?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a bunch of bugfixes, almost all for unreported bugs. The commit messages describe what each of the changes are for, feel free to ask for clarification on any of them if needed. I recommend reviewing commit-by-commit as it will make much more sense than looking at all of the changes at once.