Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1193 Changing feather range to 1-99 #1274

Merged
merged 2 commits into from Oct 3, 2019

Conversation

davidlamhauge
Copy link
Contributor

@davidlamhauge davidlamhauge commented Oct 1, 2019

This closes #1193 and #1194 .
Since the value indicates the alpha-value of the feathering, 100 = invisible. For this reason it could be argued that we should have 99 as maximum. Right now it is set to 100.

@scribblemaniac scribblemaniac added 🔹 Minor PR (only one reviewer required) Bug tool: all labels Oct 1, 2019
@MrStevns
Copy link
Member

MrStevns commented Oct 1, 2019

I'd say that it should be 1-99, the stroke shouldn't be able to go invisible since the user could consider that a bug or abnormal behaviour.

@Jose-Moreno
Copy link
Member

Jose-Moreno commented Oct 2, 2019

I agree with CandyFace, and it's actually written in the expected results for 1193. Feathering should never impede the user from painting because it's only meant to lighten the amount of color that is applied on the canvas so strokes look softer.

@davidlamhauge
Copy link
Contributor Author

davidlamhauge commented Oct 2, 2019

I agree, but as I remember the discussion we had, it was undecided, so I had to choose something. I'll change it later today.

@davidlamhauge
Copy link
Contributor Author

davidlamhauge commented Oct 2, 2019

Maximum feather set to 99.

@davidlamhauge davidlamhauge changed the title #1193 Changing feather range to 1-100 #1193 Changing feather range to 1-99 Oct 3, 2019
Copy link
Member

@MrStevns MrStevns left a comment

Tested and works after expectations

Well done 👍

@MrStevns MrStevns merged commit fd9032f into pencil2d:master Oct 3, 2019
@chchwy chchwy added this to the 0.6.5 milestone Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🔹 Minor PR (only one reviewer required)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High feathering values do not allow pixel application on canvas
5 participants