Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply more saturated color scheme to layers and highlight more distinct #1311

Merged
merged 4 commits into from Mar 6, 2020

Conversation

MrStevns
Copy link
Member

@MrStevns MrStevns commented Feb 26, 2020

In correlation to #1308 which was made to get more distinct highlight, I've come up with this change. The highlight is always based on the color behind.
layer colors

@MrStevns MrStevns changed the title Apply more saturated color scheme to layer highlight. Apply more saturated color scheme to layers and make highlight more distinct Feb 26, 2020
@MrStevns MrStevns changed the title Apply more saturated color scheme to layers and make highlight more distinct Apply more saturated color scheme to layers and highlight more distinct Feb 26, 2020
@davidlamhauge
Copy link
Contributor

davidlamhauge commented Feb 26, 2020

I can fully support this elegant solution, for a more visible highlight for the active layer.
I'm still puzzled and confused over the fact, that I was more than a year to see that there indeed was a faint white shadow on the active layer. We really need a more visible highlight for the active layer.
I might even be able to review it, if we can agree on the change 😉

@MrStevns MrStevns added the UI Related to the visual appearance of the program label Feb 28, 2020
@davidlamhauge davidlamhauge self-requested a review Mar 2, 2020
Copy link
Contributor

@davidlamhauge davidlamhauge left a comment

This PR was initiated, since I repeatedly drew on the wrong layer, since the layer highlight was too vague for me to see.
@Jose-Moreno and I have approved of the more saturated colors. If the rest of the team agree too, then let's merge it into the master.
LGTM!

Copy link
Member

@scribblemaniac scribblemaniac left a comment

Looks good to me. Honestly I've never had an issue with seeing the highlight before, it's what I always use to see what layer I'm on, but this does make it much more visible. I personally think that we should also add a gradient to the label section when not selected. Something like this for example:
Screenshot of alternative timeline tracks
That is a gradient from (255, 2555, 255, 63) to (0, 0, 0, 0) with the same code as paintSelection.
The track could also have the gradient, but it's not as noticable unless you've got a bunch of the same layer type next to each other:
Screenshot from 2020-03-04 04-21-55

@MrStevns
Copy link
Member Author

MrStevns commented Mar 5, 2020

I've applied gradient to tracks and labels that are not selected, now there's definitely no doubt that a track is selected.
gradients

@MrStevns MrStevns added this to the 0.6.5 milestone Mar 6, 2020
@MrStevns MrStevns merged commit ccaca20 into pencil2d:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Timeline UI Related to the visual appearance of the program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants