-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply more saturated color scheme to layers and highlight more distinct #1311
Conversation
I can fully support this elegant solution, for a more visible highlight for the active layer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was initiated, since I repeatedly drew on the wrong layer, since the layer highlight was too vague for me to see.
@Jose-Moreno and I have approved of the more saturated colors. If the rest of the team agree too, then let's merge it into the master.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Honestly I've never had an issue with seeing the highlight before, it's what I always use to see what layer I'm on, but this does make it much more visible. I personally think that we should also add a gradient to the label section when not selected. Something like this for example:
That is a gradient from (255, 2555, 255, 63) to (0, 0, 0, 0) with the same code as paintSelection.
The track could also have the gradient, but it's not as noticable unless you've got a bunch of the same layer type next to each other:
In correlation to #1308 which was made to get more distinct highlight, I've come up with this change. The highlight is always based on the color behind.