Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1314: Fix save dialog ignores if path is empty #1315

Merged

Conversation

MrStevns
Copy link
Member

@MrStevns MrStevns commented Mar 7, 2020

This is a quick fix for now, we should consider not opening the filedialog static, as there's no way to get the return codes this way... The save methods could also make use of Status instead for more error handling.

closes #1314

Copy link
Contributor

@davidlamhauge davidlamhauge left a comment

LGTM.
As @candyface writes, we could consider bigger changes, but this solves the problem for now.

@MrStevns MrStevns merged commit 6488999 into pencil2d:master Mar 8, 2020
@Jose-Moreno Jose-Moreno added this to the 0.6.5 milestone Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel Save will save file anyway
3 participants