-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout tweaks #1317
Layout tweaks #1317
Conversation
This makes it consistent with the vertical resizing behavior of the tool options widget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested after latest changes and looks 'correct' on mac now, well done 👍
Would be nice to move that resize chunk that's repeated inside BaseDockWidget but I can see we use a non generic ui element each time... couldn't we pass the height in as a param to the BaseDockWidget? that's a bit better than having this repeated per time we need to use the flowLayout.
Yeah it would be a good idea to make a helper function for that in BaseDockWidget. I'll try that soon. |
Alright, this is refactored and ready to go now hopefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging 👍
This PR tweaks a few parts of the display and tools dock widgets' appearance. These include:
And here are some visuals
FlowLayout Resizing:
Horizontal centering:
Note that if you move a widget with FlowLayout from floating to a dock with a smaller width, it may overflow into the widget below. I have not found a fix for this, but I don't think it is very high priority since interacting with the widget in any way will trigger some update which fixes the issue.
Also note that this has only been tested on Linux. Given the slightly hackish nature of this solution, it is possible that it will not work on some other operating system. We should test Mac and Linux before applying these changes.