Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferencemanager updated when fps changes #1340

Merged
merged 1 commit into from Apr 22, 2020

Conversation

davidlamhauge
Copy link
Contributor

@davidlamhauge davidlamhauge commented Apr 21, 2020

While working on the sound scrub feature, I accidentally found out, that the preference manager is not updated when the fps changes. The playback manager is updated, but the preference manager get the fps from the file that loads with Pencil2D, and is not updated until next time it is opened.
It has had no impact on Pencil2D, but it prevented me from an enhancement I wanted, and thus it was discovered.

@MrStevns
Copy link
Member

MrStevns commented Apr 22, 2020

LGTM, merging.

@MrStevns MrStevns merged commit e7d70e8 into pencil2d:master Apr 22, 2020
@Jose-Moreno Jose-Moreno added this to the 0.6.5 milestone May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants