Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action to open Pencil2D's temporary directory #1351

Merged
merged 1 commit into from May 15, 2020

Conversation

scribblemaniac
Copy link
Member

@scribblemaniac scribblemaniac commented May 11, 2020

Implemented as discussed. It is an action in the Help menu, and when clicked, it produces a warning message before opening the user directory. Works on Ubuntu, should be tested on other platforms.

@scribblemaniac scribblemaniac added Enhancement UX Related to the way users interact with the program labels May 11, 2020
@scribblemaniac scribblemaniac added this to the 0.6.5 milestone May 11, 2020
@scribblemaniac scribblemaniac requested a review from MrStevns May 11, 2020
@davidlamhauge
Copy link
Contributor

davidlamhauge commented May 11, 2020

I've tested it on Win10, and it works as expected.
I've also looked at the code and it looks good to me. Only thing is the 'Opening!' debug message in ActionCommands. I'd replace that line with '// TODO we must find a better solution for this'.
I'll leave the review to @candyface .

Copy link
Member

@MrStevns MrStevns left a comment

Looks good to me. Tested and works as expected 👍
I have no comment regarding the qDebug except it should be removed.

@chchwy
Copy link
Member

chchwy commented May 12, 2020

Sorry I missed the discussion. What's the purpose to provide this?

@MrStevns
Copy link
Member

MrStevns commented May 12, 2020

@chchwy The purpose of the implementation is that we often end up explaining how to get to the temporary workspace, when someone has lost their project through corruption or similar. When trying to recover the project we lead them here in any last resort to extract the last data that was saved to the temporary workspace. On mac OS you'll have to delve through "private/var" to find the folder, which is not somewhere one should be looking unless they know what they're doing... so instead of only providing the information necessary for them to get there, we provide a simple shortcut.

It's not meant to be a permanent solution, it should be replaced with a proper recovery mechanism in due time.

The rest @scribblemaniac can probably explain better, since he was the one that proposed it.

@scribblemaniac
Copy link
Member Author

scribblemaniac commented May 15, 2020

The qDebug statement was left in unintentionally. It has been fixed now.

@candyface Summed it up fine. There's not really much to this, it's an action that takes you to the temporary directory. This will simplify providing support to users who want to try and recover their project after a crash. This has previously been particularly difficult on macOS where the directory is different for everyone, but even Windows users had difficulty navigating to a hidden directory. It was extensively discussed in #feature-requests so if you have some complaint about it, it has probably already been complained about.

@scribblemaniac scribblemaniac merged commit c13aa62 into pencil2d:master May 15, 2020
1 check was pending
@scribblemaniac scribblemaniac deleted the the-button branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement UX Related to the way users interact with the program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants