Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more crashes when there is no previous frame #1388

Merged
merged 3 commits into from Jun 19, 2020

Conversation

scribblemaniac
Copy link
Member

@scribblemaniac scribblemaniac commented Jun 14, 2020

This is a follow up to #1371 and deals with the same type of issues that caused #834. Hopefully this takes care of all such issues.

…levant

There are places that only have a Q_CHECK_PTR because they
follow a call to ScribbleArea::handleDrawingOnEmptyFrame which
should guarantee a frame after invocation. However this is called only
at the start of a stroke typically, which means that if the frame is
deleted while the stroke is in progress (ex. with a shortcut), then
it will still crash without a check. Users who aren't trying to break
the program will likely never do this, but we might as well add the
checks if we know the issue is there.
…levant

See commit message of f61b6ad. This is the same thing execpt for
bitmaps.
This was causing crashes when there were no previous frames on any
layer.
@chchwy chchwy merged commit 5a4487c into pencil2d:master Jun 19, 2020
1 check passed
@Jose-Moreno Jose-Moreno added this to the 0.6.5 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants