#882 dragging keyframe displacement#1495
Merged
J5lx merged 21 commits intopencil2d:masterfrom Sep 25, 2021
Merged
Conversation
- Refactor and remove obsolete functionality
scribblemaniac
added
🔹
- Frames that are being dragged will show as slightly lifted. - Fixed a UX aspect that made dragging feel less smooth when dragging right.
MrStevns
force-pushed
the
#882-dragging-keyframe-displacement
branch
from
e4d8114 to
ce35746
Compare
Member
Author
|
Code is up to date and can now be reviewed. |
J5lx
requested changes
Sep 21, 2021
Member
J5lx
left a comment
J5lx
left a comment
There was a problem hiding this comment.
Looks pretty good overall! There’s just one bug where the offset of the frames being dragged gets messed up when the contents of the timeline are moved to the left by scrolling. Other than that there are just a handful of remarks and the usual PR for the cosmetic stuff (CandyFace#18). Nice work!
…rame-displacement/cleanup Clean up the timeline dragging changes a bit
Which means that we have to specifically check if we're holding down a mouse button, otherwise we get unexpected frame placement and selections.
This is more correct because prior to this we already check whether it's possible to move, therefore is this assertion is true, then we have a bug.
Member
Author
|
Ah nice spotted, I indeed hadn't accounted for the scroll offset when painting the moving frames! Like last time you're welcome to squash and merge when we get there |
MrStevns
force-pushed
the
#882-dragging-keyframe-displacement
branch
from
e715cb6 to
011a43b
Compare
Member
Author
|
PR updated and remarks handled. Ready for takeoff! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've rewritten the frame dragging functionality so frames can never be misplaced by accident, this means that frames will be dragged across other frames and only moved when the mouse has been released and there was space for the frames, otherwise the frames will be put back.
Changes
What's removed
Result:
The intend of dragging should be explicit and in combination with #1343, dragging and manipulating frames in general will become more intuitive.
closes #882