Fix cache bug when drawing on previous keyframe#1577
Merged
MrStevns merged 1 commit intopencil2d:masterfrom May 3, 2021
Merged
Fix cache bug when drawing on previous keyframe#1577MrStevns merged 1 commit intopencil2d:masterfrom
MrStevns merged 1 commit intopencil2d:masterfrom
Conversation
MrStevns
force-pushed
the
cache-bug-drawing-on-previous
branch
from
e8d3e10 to
498dcd5
Compare
MrStevns
changed the title
- Frame modification is never called because
MrStevns
force-pushed
the
cache-bug-drawing-on-previous
branch
from
498dcd5 to
a98600f
Compare
Member
Author
|
This has been sitting for quite some time and it's a very small change. There should be no side effects from calling onFrameModified(previousKeyFrame->pos()) in this case, except clearing the cache which will fix the bug. Therefore I will now merge the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cache issue caused by onFrameModified not being called when drawing on previous keyframe, making the latest stroke invisible upon release event.
closes #1576