Merged
Conversation
Additional changes: - Fix cache issue caused by not calling frameModified. - Make PegbarResult -> PegStatus, inherits from Status now. - Implement ability to update status while keeping data.
- "Select" tool will be set upon opening the dialog - A selection will be made unless one already exists - First layer will be pre-selected Other: - Make sure dialogs are being closed when starting a new project context. Cleanup code...
MrStevns
added
Bug
Enhancement
UX
MrStevns
force-pushed
the
pegbar-issues
branch
from
647fa34 to
8263989
Compare
J5lx
requested changes
Mar 1, 2021
Member
J5lx
left a comment
J5lx
left a comment
There was a problem hiding this comment.
Looking good so far, I like that the aligner has its own class now. However, a few issues are still left. First of all, here’s a PR with minor changes, as usual: CandyFace#13. As for the other issues:
- When the current position on the timeline is before the first frame, opening the peg bar dialog leads to a segfault
- Simply closing the peg bar dialog leads to a segfault
- When a selection exists before opening the dialog, it is necessary to deselect, then reselect the layer in order for the align button to become enabled
- The selection is lost when the dialog is closed, even when the user didn’t actually confirm the dialog. Either way I’m not really sure what the intention behind that is.
Peg Bar Alignment Minor Tweaks
Member
Author
|
All but one change has been addressed, not what to do with the last one as we can't make use of the existing functions, the way we've hooked actions directly to the manager. |
…lification Simplify toolbox slots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is focused on moving pegbar related code into its own core class but it contains a bunch of improvements and fixes too.
Among the list of changes:
Quality of life improvements:
Other:
Cleanup code...