Fix more cache issues.#1581
Merged
Merged
Conversation
Caused cache to not be updated when interpolating.
MrStevns
force-pushed
the
bugfix/cache-issues
branch
from
efdd90a to
6ecbbdb
Compare
davidlamhauge
requested changes
Mar 1, 2021
Contributor
davidlamhauge
left a comment
davidlamhauge
left a comment
There was a problem hiding this comment.
Almost everything works perfect.
Camera interpolation works only when you are on the camera layer. If you choose the Bitmap or Vector layer, the camera interpolation is not updated.
Besides that: Good work!
This should happen regardless of whether we're on a camera layer or not.. because of potential camera interpolation.
Member
Author
|
The interpolation issue should be fixed now and the review requests should have been addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another PR, this one focuses on the ongoing cache regressions that returned after i reworked the logic...
What's added: