Onion skin panel touchups#1589
Merged
MrStevns merged 3 commits intopencil2d:masterfrom Apr 5, 2021
Merged
Conversation
Also removed some unnecessary elements that were there for layout purposes, but the same effect could be achieved without them. The opacity is split up into to QHBoxLayouts in prepartion for adding a FlowLayout in the next commit.
MrStevns
approved these changes
Apr 5, 2021
Member
MrStevns
left a comment
There was a problem hiding this comment.
LGTM. there's a small mis-alignment with the two spinboxes when they're below each-other... Normally I'd fix it with a QGridLayout but since Grid layout doesn't play well with a flow layout, I say we ignore that small detail for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some small modifications to the onion skin panel with the primary goal of decreasing the minimum width of the panel, and cleaning up the underlying structure a bit. Summary of changes:
Here is a comparison of the minimum configurations before and after.



Before:
After (min width):
After (min height):
As you can see, it can now have a considerably smaller width. The group boxes actually add a little bit to the height and width though, but I think it's worth it for the improved readability of the panel overall.