Prevent stuck cursor icon when transitioning from MMB to RMB#1633
Merged
MrStevns merged 1 commit intopencil2d:masterfrom May 11, 2021
Merged
Prevent stuck cursor icon when transitioning from MMB to RMB#1633MrStevns merged 1 commit intopencil2d:masterfrom
MrStevns merged 1 commit intopencil2d:masterfrom
Conversation
Member
|
I can't verify whether it fixes the problem or not, as I can't reproduce the bug at all on Mac OS.. This is with a mouse however, I don't have my tablet setup currently. I will merge the change, then @Jose-Moreno can test if it works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes call to
HandTool::pointerReleaseEvent, which would callScribbleArea::setPrevTool, which would callToolManager::setCurrentToolwhere it would set the previously used tool, but theHandTool::pointerReleaseEventwould go on, causing an icon-function mismatch.Fixes #1198