Merged
Conversation
scribblemaniac
added
Enhancement
Sound
UX
MrStevns
reviewed
Mar 26, 2022
Member
Author
|
This is going to conflict with #1690 so I think merging this PR should wait until that PR is merged and I have had a chance to add this check when duplicating the sound layer as well. |
chchwy
reviewed
May 13, 2022
Member
|
Doesn’t this check still need to be added when duplicating a sound layer as well, as scribble said? |
Member
Agh... I managed to skip that part, yes it should. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Pencil2D can't export animations with >= 63 frames due to limitations with the ffmpeg filter inputs. This warns the user when they've added too many sound clips, and produces a more specific error when attempting to export an animation with too many sound clips.
This could be improved, but I think it's good enough for a temporary solution. I have a movie exporter rewrite partially finished which I would like to complete before making changes to the ffmpeg command to allow for any number of sound clips to be exported. This could be a while out though, so I think this is a reasonable solution in the mean time.