Camera - painting changes and fixes

[MrStevns]

UI change:

• Handles are now white with thicker outline, to differentiate better between active/disabled state

Active:

Disabled:

Fixes:

• Only show skinning under playback if enabled
• Camera handles are only shown while camera tool is active
• Camera interpolation dots are only shown while camera tool is active
• Camera field is not shown during playback
• Fix onion skinning was applied per keyframe.

[J5lx]

Looks good all in all, there are only two small issues I found:

• the interpolation dots are now shown during playback.
• the inactive handles blend into the background too much. It does make sense to make them more subtle, but this is a bit too much.

Also, how come you removed the dashed lines to the control points? I thought they were a useful visual aid.

But yeah, that aside the PR looks good!

[MrStevns]

the interpolation dots are now shown during playback.

This is intentional, given that they're only visible now when: you're on a camera layer and the "show paths" are toggled on. It's not related to onion skinning, so it is not affected by "Show during playback"

the inactive handles blend into the background too much. It does make sense to make them more subtle, but this is a bit too much.

Fair point, i'll tweak it.

Also, how come you removed the dashed lines to the control points? I thought they were a useful visual aid.

I don't think the dashed line provide any meaningful addition to the UI when you have the dots to represent the curve but if you think it's useful, i'll bring it back.

[J5lx]

LGTM, thanks for your work!