Merged
Conversation
e1c00fc to
73746ce
Compare
Member
MrStevns
reviewed
Sep 24, 2023
MrStevns
reviewed
Sep 24, 2023
Member
MrStevns
left a comment
There was a problem hiding this comment.
The changes looks good to me and as mentioned, it also works as expected. I just have one thing I'd like clarified before approving.
f4c5da1 to
2c82e61
Compare
Member
Author
Member
2c82e61 to
d3ab813
Compare
Member
Author
|
Sorry for the commit spam, I had to wrestle with the CI a bit… But now everything is working and the PR is ready for review/merge again.
I wrote “for those not yet on Windows 11” in the OP, but perhaps I should have been more explicit, sorry for the confusion. |
Member
Ah that's on me, I managed to skillfully miss the "not yet" part and did exactly what I shouldn't have then 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Just as it says in the title – a little enhancement for those not yet on Windows 11 which I prepared while working on #848. To try it locally, simply download and extract the Windows artifact from the “Checks” tab of this PR, right-click pencil2d.exe and select “Pin to Start”. This will of course become more useful in conjunction with the installer PR, but it is already functional on its own.
In order to generate the package resource index for the tile images locally, the makepri tool from the Windows SDK must be available – but it is not needed when building only the program itself.