Fix crash when importing image to empty frame on hidden layer#1820
Merged
Conversation
J5lx
added
Bug
Timeline
UI
J5lx
commented
Apr 13, 2024
| * @return The newly created keyframe or `nullptr` if the layer is not visible | ||
| * @see Editor::addNewKey() | ||
| */ | ||
| KeyFrame* addKeyFrame(int layerNumber, int frameIndex); |
Member
Author
There was a problem hiding this comment.
second parameter renamed so declaration matches definition
MrStevns
approved these changes
Apr 14, 2024
Member
MrStevns
left a comment
MrStevns
left a comment
There was a problem hiding this comment.
Crash confirmed fixed.
Additional changes looks good to me too 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the crash reported at https://discuss.pencil2d.org/t/pencil2d-crashes-when-i-import-an-image-to-a-hidden-layer/8016?u=j5lx.