New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .tiff (doesn't work) and add warning if file is not imported #948

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Projects
None yet
3 participants
@CandyFace
Member

CandyFace commented Apr 15, 2018

strImgFileLower was only used as a mean to check the file extension but never used with importImage(QString). The if statement is unnecessary because we filter the allowed file formats to be imported via pencildef.h

Prior to this, if the file format was read as invalid from the if statement, the for loop would simply continue. This could lead to files not being imported correctly.

I've also removed .tiff format because it doesn't appear to be working.

@scribblemaniac

This comment has been minimized.

Contributor

scribblemaniac commented Apr 15, 2018

strImgFileLower was only used as a mean to check the file extension but never used with importImage(QString)

I'm pretty sure this was intentional. If the user want's to import Image.png, you don't want to import the potentially different file image.png on case-sensitive file systems.

@CandyFace CandyFace force-pushed the CandyFace:import-sequence-1 branch from 15fd976 to b4beb0a Apr 15, 2018

@CandyFace

This comment has been minimized.

Member

CandyFace commented Apr 15, 2018

Ah right... yeah I guess that makes sense. I've added a warning in case something should go wrong instead.

@CandyFace CandyFace changed the title from Remove .tiff (doesn't work) and unnecessary check to Remove .tiff (doesn't work) and add warning if file is not imported Apr 15, 2018

@scribblemaniac

This comment has been minimized.

Contributor

scribblemaniac commented Apr 15, 2018

You should still remove the tif/tiff extension though or file an issue to try and find a solution. I can confirm that tiff sequence import does not appear to be working.

Edit: I see you've already removed it from pencildef.h, but it is still being checked in the if statement.

@CandyFace CandyFace force-pushed the CandyFace:import-sequence-1 branch from b4beb0a to 84bce51 Apr 15, 2018

@chchwy chchwy merged commit 5155af9 into pencil2d:master Apr 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@CandyFace CandyFace deleted the CandyFace:import-sequence-1 branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment