New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable onion skin while playing #954

Merged
merged 2 commits into from May 13, 2018

Conversation

Projects
None yet
3 participants
@CandyFace
Member

CandyFace commented Apr 22, 2018

#378 onion skin should be disabled on playback.

mission accomplished 馃

@Jose-Moreno

This comment has been minimized.

Member

Jose-Moreno commented Apr 22, 2018

@CandyFace ouch I didnt see this before. Is it possible to make this toggable? I normally do use onion skin while doing playback to check the spacing between the drawings at full speed.

Edit: Apologies, forgot to congratulate you on the good work. Thank you once more for taking care of these important tasks! 馃檪

@CandyFace

This comment has been minimized.

Member

CandyFace commented Apr 22, 2018

No worries :)

It is not toggable atm. but i'll make sure it will be if you find it useful

@CandyFace

This comment has been minimized.

Member

CandyFace commented Apr 23, 2018

@Jose-Moreno I've made it optional now ;)
screen shot 2018-04-23 at 18 17 53

@Jose-Moreno

This comment has been minimized.

Member

Jose-Moreno commented Apr 23, 2018

@CandyFace Aww man, thanks! I know most people get annoyed by seeing the onion skin on playback, but even pro software do have the ability to toggle the onion skin on playback since sometimes even if you "flip" through the frames by hand, it's different when you see the gaps between the drawings at playback speed.

Normally what I had to do was just to turn off the onion skin and play a few times, then turn it on again and play the animation a few more 馃槅

Again thanks a lot!

@chchwy

This comment has been minimized.

Member

chchwy commented May 13, 2018

Reviewing

@chchwy chchwy self-assigned this May 13, 2018

@chchwy

This comment has been minimized.

Member

chchwy commented May 13, 2018

Generally the PR is good, appreciate your work @CandyFace!

I found that Pixmap cache is broken at the moment when reviewing the code. it means every time we play the animation it repaint everything even it can be cached. It's not related to this PR though. Just keep a note.

@chchwy chchwy merged commit 6a5711f into pencil2d:master May 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@CandyFace CandyFace deleted the CandyFace:#378-disable-onion branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment