refactor: extract ReportIdempotency constants

penguin-statistics · Aug 15, 2022 · 9d8137e · 9d8137e
1 parent 313cb0a
commit 9d8137e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/internal/constant/report.go b/internal/constant/report.go
@@ -1,5 +1,7 @@
 package constant
 
+import "time"
+
 const (
 	FurnitureArkItemID = "furni"
 
@@ -20,6 +22,9 @@ const (
 
 	ViolationReliabilityRejectRuleRangeLeast = 1 << 8
 	ViolationReliabilityRejectRuleRangeMost  = 1 << 10
+
+	ReportIdempotencyLifetime     = time.Hour * 24
+	ReportIdempotencyRedisHashKey = "report-idempotency"
 )
 
 // DropTypeMap maps an API drop type to a database drop type.

diff --git a/internal/controller/v2/report.go b/internal/controller/v2/report.go
@@ -3,7 +3,6 @@ package v2
 import (
 	"encoding/json"
 	"strings"
-	"time"
 
 	"github.com/go-redis/redis/v8"
 	"github.com/gofiber/fiber/v2"
@@ -32,7 +31,7 @@ type Report struct {
 
 func RegisterReport(v2 *svr.V2, c Report) {
 	v2.Post("/report", middlewares.Idempotency(&middlewares.IdempotencyConfig{
-		Lifetime:  time.Hour * 24,
+		Lifetime:  constant.ReportIdempotencyLifetime,
 		KeyHeader: constant.IdempotencyKeyHeader,
 		KeepResponseHeaders: []string{
 			fiber.HeaderContentType,
@@ -41,7 +40,7 @@ func RegisterReport(v2 *svr.V2, c Report) {
 			constant.PenguinIDSetHeader,
 			constant.ShimCompatibilityHeaderKey,
 		},
-		Storage: fiberstore.NewRedis(c.Redis, "report-idempotency"),
+		Storage: fiberstore.NewRedis(c.Redis, constant.ReportIdempotencyRedisHashKey),
 	}), c.SingularReport)
 	v2.Post("/report/recall", c.RecallSingularReport)
 	v2.Post("/report/recognition", c.RecognitionReport)