From c57f5a27263564cab09b8c5cb13fe4093d3a3e3a Mon Sep 17 00:00:00 2001 From: GalvinGao Date: Sat, 20 Aug 2022 17:13:44 -0400 Subject: [PATCH] feat: improve service marking using semconv --- internal/server/httpserver/http.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/server/httpserver/http.go b/internal/server/httpserver/http.go index 1ebb1afd..7a17eb50 100644 --- a/internal/server/httpserver/http.go +++ b/internal/server/httpserver/http.go @@ -3,6 +3,7 @@ package httpserver import ( "context" "fmt" + "os" "runtime" "strings" "time" @@ -19,7 +20,6 @@ import ( "github.com/rs/zerolog/log" "github.com/samber/lo" "go.opentelemetry.io/otel" - "go.opentelemetry.io/otel/attribute" "go.opentelemetry.io/otel/exporters/jaeger" "go.opentelemetry.io/otel/exporters/otlp/otlptrace" "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc" @@ -113,7 +113,8 @@ func CreateServiceApp(conf *config.Config) *fiber.App { semconv.SchemaURL, semconv.ServiceNameKey.String("pgbackend"), semconv.ServiceVersionKey.String(bininfo.Version), - attribute.String("environment", lo.Ternary(conf.DevMode, "dev", "prod")), + semconv.ServiceInstanceIDKey.String(lo.Must(os.Hostname())), + semconv.DeploymentEnvironmentKey.String(lo.Ternary(conf.DevMode, "dev", "prod")), )), tracesdk.WithSampler( tracesdk.ParentBased(