Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab oauth support #964

Closed
thenewguy opened this issue May 31, 2015 · 7 comments
Closed

Gitlab oauth support #964

thenewguy opened this issue May 31, 2015 · 7 comments

Comments

@thenewguy
Copy link

It would be handy if gitlab oauth was supported on custom domains

See http://doc.gitlab.com/ce/integration/oauth_provider.html

@pennersr
Copy link
Owner

Indeed. Feel free to reopen or submit a pull request once you have got something working...

@takotuesday
Copy link

This is something that certainly interests me as well!

@ghost
Copy link

ghost commented Jul 16, 2015

@pennersr could this issue please be reopened. As noted on readthedocs/readthedocs.org#1441 there is need for this functionality.

@takotuesday
Copy link

It looks like gitlab and github's web application flow is pretty similar, so a lot of the github provider could potentially be re-usable.

@takotuesday
Copy link

@pennersr it seems to me that a hurdle in adding gitlab is it is designed to be used in for in house hosting and under a custom domain, unlike github who has a fixed domain. There are a couple ways to work around this:

  • set the domain in the database
  • set the domain in the settings file

Which would you reccomend? Is there an approach that I am missing?

@pennersr
Copy link
Owner

There is currently no proper place for this to be stored in the database. A settings sounds more in line to what we have now:

SOCIALACCOUNT_PROVIDERS = { 'gitlab': { 'DOMAIN': ... and so on }}

@saily
Copy link
Contributor

saily commented Dec 18, 2015

i've added this feature in: #1231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants