Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basecamp provider #1077

Merged
merged 11 commits into from Sep 26, 2015

Conversation

@yrik
Copy link
Contributor

commented Aug 5, 2015

No description provided.

@pennersr

This comment has been minimized.

Copy link
Owner

commented Sep 17, 2015

Thanks! Can you add the provider to the test_settings.py?

@yrik

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2015

@pennersr Thanks for notice, added it.

See strange error connected with python 3.2 support of coverage package.

yrik added some commits Sep 20, 2015

@yrik

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2015

Created pull request on coveragepy to fix this issue https://bitbucket.org/ned/coveragepy/pull-requests/69/remove-unnecessary-u-prefixes-for-better/diff

Temporary used direct link to fixed repo. With fixed repo all tests goes ok.
Should I specify coverage version from pypy to have this pull-request accepted?

@yrik

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2015

Ned from coveragepy suggested to use version 3.7.1 of coverage. Specified it in .travis.yml and tests goes ok.

@pennersr

This comment has been minimized.

Copy link
Owner

commented Sep 26, 2015

Thanks!

pennersr added a commit that referenced this pull request Sep 26, 2015

Merge pull request #1077 from 7WebPages/master
Add Basecamp provider

@pennersr pennersr merged commit 102362e into pennersr:master Sep 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.