create base email template for easier customizability #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
pennersr
reviewed
Oct 6, 2020
| @@ -1,8 +1,8 @@ | |||
| {% load account %}{% user_display user as user_display %}{% load i18n %}{% autoescape off %}{% blocktrans with site_name=current_site.name site_domain=current_site.domain %}Hello from {{ site_name }}! | |||
| {% extends 'base.txt' %}{% load account %}{% block content %}{% user_display user as user_display %}{% load i18n %}{% autoescape off %}{% blocktrans with site_name=current_site.name site_domain=current_site.domain %}Hello from {{ site_name }}! | |||
There was a problem hiding this comment.
Perhaps it would be better to have a allauth/templates/account/email/base_message.txt so that it is clear that this base is email message specific, and, it is scoped within the allauth template context.
|
Closed via 14108d7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
it would be pretty useful to have a
base.txtto overwrite for easier extensability, similar tobase.html.There are countries out there (including mine) which demand by law that you have an imprint in every mail you send as an organization.
Right now you need to copy all relevant mail templates into your project and edit every single template. Additionally, you need to repeat that if the mail templates will be updated.
This PR is my suggestion to add a
base.txttotemplates/which only contains{% block content %}{% endblock content %}. This way one can add custom stuff (e.g. an imprint).