feat(accounts): add key to password reset template #3108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the password reset email template gets passed the full URL to the password reset endpoint. However, in some scenarios, this endpoint isn't the location where the user will actually perform the password reset data entry, for example if Django only hosts an API backend and the user-facing part instead is implemented via a SPA. To make it easier to integrate such setups with allauth, this change additionally passes the uid and key to the password reset email template. This provides full control to the template author to generate their own password reset links and support a split frontend/backend.
Contributor
Author
|
Note the similar use-case in #3081; I believe the implementation provided here is more generic as the path variable can now be reconstructed in the template via |
|
Makes sense to me. I'll close my PR in favor of this one |
Contributor
Author
|
@pennersr Any chance we could get this PR reviewed? Thanks in advance! |
Contributor
Author
|
TYSM for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the password reset email template gets passed the full URL to
the password reset endpoint. However, in some scenarios, this endpoint
isn't the location where the user will actually perform the password
reset data entry, for example if Django only hosts an API backend and
the user-facing part instead is implemented via a SPA.
To make it easier to integrate such setups with allauth, this change
additionally passes the uid and key to the password reset email
template. This provides full control to the template author to generate
their own password reset links and support a split frontend/backend.