Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google): Make API URLs configurable #3236

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jan 16, 2023

This is a change similar to #3187. This pull request makes the Google API URL configurable via a provider setting which enables use-cases such as overriding the endpoint during integration tests to talk to a fake version of the API.

@coveralls
Copy link

coveralls commented Jan 16, 2023

Coverage Status

Coverage: 91.663% (-0.04%) from 91.701% when pulling a22890d on c-w:configure-google-endpoints into 30a3473 on pennersr:master.

This change makes the Google API URLs configurable via a provider
setting which enables use-cases such as overriding the endpoint during
integration tests to talk to a fake version of the API.
@c-w c-w force-pushed the configure-google-endpoints branch from d307bd7 to a22890d Compare January 16, 2023 13:11
@pennersr pennersr merged commit b969653 into pennersr:master Mar 16, 2023
@c-w c-w deleted the configure-google-endpoints branch March 16, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants