Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopefully fixes @mail going forward #1321

Merged
merged 1 commit into from Jan 25, 2020
Merged

Hopefully fixes @mail going forward #1321

merged 1 commit into from Jan 25, 2020

Conversation

@captdeaf
Copy link
Contributor

captdeaf commented Jan 24, 2020

I don't have enough time to duplicate the issue in Penn to figure out if this is the actual cause and correct fix, but here's the what I'm figuring:

  1. chunk_read doesn't null terminate. This probably doesn't impact anywhere else except mail.c since get_message might be the only one to assume it does? There's also a possibility that things are saved into chunks with null_terminator, pulled out with it, then saved again without it. Just plain ugh.
  2. Replace all the strcpy()s in extmail.c with mush_strncpy()s. Also? Hate for the non-#defined numbers. 30, 50 instead of SENDER_LEN and SUBJECT_LEN, etc etc?

Thoughts on other possible causes:

  1. Loading in one form of @config chunk and dumping in a separate might have been a cause?
  2. Interplay between some particular uncompress()/compress(), chunk_fetch()/chunk_create() and getstring(), etc ...
@captdeaf captdeaf requested a review from talvo Jan 24, 2020
@talvo
talvo approved these changes Jan 25, 2020
Copy link
Member

talvo left a comment

Sure as fuck can't make things worse.

@captdeaf captdeaf merged commit 0705c68 into pennmush:master Jan 25, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.