Skip to content

bug: slashes in board name cause directories to be created in zip export #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
networkException opened this issue Jun 3, 2023 · 1 comment · Fixed by #3391
Closed

bug: slashes in board name cause directories to be created in zip export #3276

networkException opened this issue Jun 3, 2023 · 1 comment · Fixed by #3391
Assignees
@Alotor
Labels
bug managed on taiga This issue has been moved to our project at Taiga.io
Milestone
1.19.0

Comments

@networkException
Copy link

Steps To Reproduce

  1. Create at least two boards
  2. Name one of them "Something / something" or even "Something / ../../../something"
  3. Select both boards
  4. Use Export Selection (with type PDF) to export both boards as a ZIP archive

Expected behavior

The zip file should contain both slides as PDFs with the proper names set

Actual behavior

THe zip file contains directories

Screenshots or video

No response

Desktop (please complete the following information)

  • Chromium 113.0.5672.93

Smartphone (please complete the following information)

No response

Environment (please complete the following information)

  • Ubuntu 22.04
  • Docker Compose
  • Penpot 1.18.3

Frontend Stack Trace

No response

Backend Stack Trace

No response

Additional context

No response
@superalex
Copy link
Contributor

superalex commented Jun 5, 2023 •
edited
Loading

Thank you very much for the report.

I've just added https://tree.taiga.io/project/penpot/issue/5423 to manage it, I hope we can fix it soon.

@superalex superalex added the managed on taiga This issue has been moved to our project at Taiga.io label Jun 5, 2023
@Alotor Alotor self-assigned this Jul 7, 2023
@Alotor Alotor added this to the 1.19.0 milestone Jul 7, 2023
@Alotor Alotor linked a pull request Jul 7, 2023 that will close this issue
Alotor bugfixes 3 #3391
Merged
@Alotor Alotor mentioned this issue Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alotor Alotor

Labels
bug managed on taiga This issue has been moved to our project at Taiga.io
Projects
None yet
Milestone
1.19.0
Development

Successfully merging a pull request may close this issue.

Alotor bugfixes 3 penpot/penpot
3 participants
@superalex @Alotor @networkException