Skip to content

🐛 Distribute fix enabled when two elements were selected - #3266

Merged
superalex merged 1 commit into
penpot:developfrom
dfelinto:fix-distribute-enable
Jun 5, 2023
Merged

🐛 Distribute fix enabled when two elements were selected#3266
superalex merged 1 commit into
penpot:developfrom
dfelinto:fix-distribute-enable

Conversation

@dfelinto

Copy link
Copy Markdown
Contributor

The distribute operations only make sense when there are at least 3 selected elements. Unlike the alignment ones which indeed should be enabled if there are at least two elements selected.

Current behavior:

image

Expected (patch) behavior:

image

@superalex superalex self-assigned this Jun 2, 2023
@superalex

Copy link
Copy Markdown
Contributor

Hi @dfelinto

Thank you very much for your PR, just a few comments:

@dfelinto

dfelinto commented Jun 2, 2023

Copy link
Copy Markdown
Contributor Author

Hi, I will do it, no problems.


By the way when I created the Pull Request, the default template actually says to use:
2. PR name follows [convention](http://karma-runner.github.io/4.0/dev/git-commit-msg.html)

Which is why I went with fix(<type>). This is what I see at the moment:

image

The distribute operations only make sense when there are at least 3
selected elements.

-----------------

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Dalai Felinto <dalai@blender.org>
@dfelinto
dfelinto force-pushed the fix-distribute-enable branch from 4074849 to a6155f9 Compare June 2, 2023 16:44
@dfelinto dfelinto changed the title fix(frontend): distribute fix enabled when two elements were selected 🐛 Distribute fix enabled when two elements were selected Jun 2, 2023
@dfelinto

dfelinto commented Jun 2, 2023

Copy link
Copy Markdown
Contributor Author

Done, also updated #3267 :)

@superalex

superalex commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Great!, thank you very much! :)

I've added your contribution here -> https://github.com/penpot/penpot/blob/develop/CHANGES.md?plain=1#L31

@superalex
superalex merged commit c228f2f into penpot:develop Jun 5, 2023
@dfelinto
dfelinto deleted the fix-distribute-enable branch June 5, 2023 08:41
Lobster-0429 pushed a commit to Lobster-0429/penpot that referenced this pull request May 4, 2026
🐛 Distribute fix enabled when two elements were selected
SaiMahitVaddadi pushed a commit to SaiMahitVaddadi/penpot that referenced this pull request Jun 10, 2026
🐛 Distribute fix enabled when two elements were selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants