Skip to content

🐛 Change independent corner radius input tooltips #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

🐛 Change independent corner radius input tooltips #3332

wants to merge 3 commits into from

Conversation

astudentinearth
Copy link
Contributor

Make the inputs show a tooltip for the relevant corner(e.g. "Top left") instead of "Radius".
Completes #3305 (Taiga #5486)
This pull request does not introduce breaking changes.

After the change the tooltips are shown like this:
image

Make the inputs show a tooltip for the relevant corner(e.g. "Top left") instead of "Radius"

Signed-off-by: Burak Yeniçeri <burak.yn.dev@gmail.com>
@superalex
Copy link
Contributor

Hey!, thank you very much @astudentinearth

As radius and interactions are two different concepts I think it would be a good idea using new translation keys. Even if right now they have the same translation, if in the future they change it will affect this too.

You could create the new keys for every language and copy the translations from each language.

@superalex superalex self-assigned this Jun 22, 2023
@astudentinearth
Copy link
Contributor Author

@superalex I understand the concerns about translation keys. I will look into it once I'm available.

@superalex
Copy link
Contributor

Great!, thank you very much :)

astudentinearth and others added 2 commits June 22, 2023 15:20
Create the keys and copy relevant position strings from already existing `workspace-interaction-pos` keys. Update `measures.cljs` to use the new keys.

Signed-off-by: Burak Yeniçeri <burak.yn.dev@gmail.com>
@astudentinearth
Copy link
Contributor Author

I have created the new language keys, however I synced my fork branch with origin/develop on the web interface, so there is a merge commit in between. Would that cause a problem?

@superalex superalex added this to the 1.19.0 milestone Jun 27, 2023
@superalex
Copy link
Contributor

Thank you very much!, I've just merged manually this :)

@superalex superalex closed this Jun 27, 2023
@astudentinearth
Copy link
Contributor Author

@superalex Thanks a lot. This was my first ever pull request❤️

@superalex
Copy link
Contributor

@superalex Thanks a lot. This was my first ever pull requestheart

It is a great honour for us! <3 <3 <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants