Add text outline to ruler dimensions.#78
Closed
studiospring wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Sean Loughman <sean@studiospring.com.au>
Signed-off-by: Sean Loughman <sean@studiospring.com.au>
Contributor
Author
|
Now uses canvas colour for outline. |
Contributor
|
What do you think about this @elhombretecla From my point of view it looks nice, but the final decision is yours. |
Contributor
|
In any case, don't merge it. I want make some code style tweaks before ;) |
Contributor
|
Thank you so much for this issue and for your work @studiospring I'm agree with you. We need to improve this design. Your proposal is good but I think that we have to try to continue with the visual hierachy. Thats why I think this tooltip design is more apropiate with the other ones.
|
Contributor
Author
|
I see what you mean @elhombretecla. It would be nice if the background expanded with the text though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time, so I hope I'm doing this right ;-)
I have fixed #75 in a different way to @niwinz, by adding a text outline. I think this is a cleaner design. Sorry I couldn't do this before you got your solution finished. Let me know what you think.
Signed-off-by: Sean Loughman sean@studiospring.com.au