From fb96cba7b6f5ba0a1fe8e42886b8900dc8239ecc Mon Sep 17 00:00:00 2001
From: Joshua Sunshine <sunshine@cs.cmu.edu>
Date: Mon, 10 Jan 2022 11:32:04 -0500
Subject: [PATCH] children -> childrenAD

---
 packages/core/src/engine/Autodiff.ts | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/packages/core/src/engine/Autodiff.ts b/packages/core/src/engine/Autodiff.ts
index 339961c7c1..08e5e2ca0e 100644
--- a/packages/core/src/engine/Autodiff.ts
+++ b/packages/core/src/engine/Autodiff.ts
@@ -465,7 +465,6 @@ export const min = (v: VarAD, w: VarAD, isCompNode = true): VarAD => {
  * Return `maxN(xs)`.
  */
 export const maxN = (xs: VarAD[], isCompNode = true): VarAD => {
-
   if (xs.length === 0) {
     log.trace("node", xs);
     throw Error("argument list to maxN is empty; expected 1+ elements");
@@ -480,13 +479,13 @@ export const maxN = (xs: VarAD[], isCompNode = true): VarAD => {
     if (isCompNode) {
       for (const x of xs) {
         const xNode = ifCond(lt(x, z, false), gvarOf(0.0), gvarOf(1.0), false);
-        x.parents.push({ node: z, sensitivityNode: just(xNode) });
-        z.children.push({ node: x, sensitivityNode: just(xNode) });
+        x.parentsAD.push({ node: z, sensitivityNode: just(xNode) });
+        z.childrenAD.push({ node: x, sensitivityNode: just(xNode) });
       }
     } else {
       for (const x of xs) {
-        x.parentsGrad.push({ node: z, sensitivityNode: none });
-        z.childrenGrad.push({ node: x, sensitivityNode: none });
+        x.parentsADGrad.push({ node: z, sensitivityNode: none });
+        z.childrenADGrad.push({ node: x, sensitivityNode: none });
       }
     }
     return z;
@@ -497,7 +496,6 @@ export const maxN = (xs: VarAD[], isCompNode = true): VarAD => {
  * Return `minN(xs)`.
  */
 export const minN = (xs: VarAD[], isCompNode = true): VarAD => {
-
   if (xs.length === 0) {
     log.trace("node", xs);
     throw Error("argument list to minN is empty; expected 1+ elements");
@@ -511,14 +509,14 @@ export const minN = (xs: VarAD[], isCompNode = true): VarAD => {
 
     if (isCompNode) {
       for (const x of xs) {
-        const xNode = ifCond(gt(x, z, false), gvarOf(0.0), gvarOf(1.0), false)
-        x.parents.push({ node: z, sensitivityNode: just(xNode) });
-        z.children.push({ node: x, sensitivityNode: just(xNode) });
+        const xNode = ifCond(gt(x, z, false), gvarOf(0.0), gvarOf(1.0), false);
+        x.parentsAD.push({ node: z, sensitivityNode: just(xNode) });
+        z.childrenAD.push({ node: x, sensitivityNode: just(xNode) });
       }
     } else {
       for (const x of xs) {
-        x.parentsGrad.push({ node: z, sensitivityNode: none });
-        z.childrenGrad.push({ node: x, sensitivityNode: none });
+        x.parentsADGrad.push({ node: z, sensitivityNode: none });
+        z.childrenADGrad.push({ node: x, sensitivityNode: none });
       }
     }
     return z;