New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Failing tests #833

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Advent51
Contributor

Advent51 commented Feb 14, 2017

Test was updated and now passes succesfully

@wingman-pentaho

This comment has been minimized.

Show comment
Hide comment
@wingman-pentaho

wingman-pentaho Feb 14, 2017

Build Completed

This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -fn -DrunITs=true -f pom.xml clean install && mvn -B -f pom.xml site

Cleanup Commands

mvn -B -f pom.xml build-helper:remove-project-artifact

Changed files

  mondrian/src/it/java/mondrian/rolap/NativeEvalVirtualCubeTest.java
  mondrian/src/it/java/mondrian/rolap/agg/SegmentBuilderTest.java

Newly Broken Tests:

mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderNoWildcards:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderThreeSegs:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithData:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithEmptySegmentBody:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {time_by_day.month_of_year=('2','3','4','5','6','7')}
    {time_by_day.quarter=('Q1','Q2','Q3')}
    {time_by_day.the_year=('1998')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[208c5162e6bb49ceb217eab3621f4fc0209f73265c291a3f8aa673aee775de81]
, *Segment
mondrian.rolap.NativeEvalVirtualCubeTest.testShouldUseCache:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
expected query [select
    `customer`.`gender` as `c0`
from
    `customer` as `customer`,
    `sales_fact_1997` as `sales_fact_1997`
where
    `sales_fact_1997`.`customer_id` = `customer`.`customer_id`
group by
    `customer`.`gender`
order by
    ISNULL(`c0`) ASC, `c0` ASC] did not occur
	at junit.framework.Assert.fail(Assert.java:47)
	at mondrian.rolap.BatchTestCase.assertQuerySqlOrNot(BatchTestCase.java:523)
	at mondrian.rolap.NativeEvalVirtualCubeTest.t

Newly Fixed Tests:

mondrian.test.CompoundSlicerTest.testBugMondrian899:

🔵 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{[Time].[1997].[Q1].[2]}
{[Time].[1997].[Q1].[3]}
{[Time].[1997].[Q2].[4]}
{[Time].[1997].[Q2].[5]}
{[Time].[1997].[Q2].[6]}
{[Time].[1997].[Q3].[7]}
{[Time].[1997].[Q3].[8]}
{[Time].[1997].[Q3].[9]}
{[Time].[1997].[Q4].[10]}
{[Time].[1997].[Q4].[11]}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Spokane].[Wildon Cameron]}
{[Customers].[USA].[WA].[Spokane].[Emily Barela]}
{[Customers].[USA].[WA].[Spokane].[Dauna Barton
mondrian.test.CompoundSlicerTest.testCompoundAggCalcMemberInSlicer1:

🔵 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Compound aggregated member should return same results with native filter on/off expected:<...Janis Strunk]}
{[Customers].[USA].[OR].[Albany].[L. Albert Wall]}
{[Customers].[USA].[OR].[Albany].[Norman Arnold]}
{[Customers].[USA].[OR].[Albany].[Pauline Kubitschek]}
{[Customers].[USA].[OR].[Albany].[Peggy Denton]}
{[Customers].[USA].[OR].[Albany].[Roslyn Jasper]}
{[Customers].[USA].[OR].[Albany].[Tina Heidi]}
{[Customers].[USA].[OR].[Albany].[Veronica Sulkind]}
{
mondrian.test.NamedSetTest.testHierarchizeNamedSetImmutable:

🔵 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Yakima].[Tracy Meyer], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[Vanessa Thompson], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[Velma Lykes], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[William Battaglia], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[W
mondrian.test.NamedSetTest.testNamedSetRangeInSlicerPrimed:

🔵 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{[Time].[1997].[Q1].[2]}
{[Time].[1997].[Q1].[3]}
{[Time].[1997].[Q2].[4]}
{[Time].[1997].[Q2].[5]}
{[Time].[1997].[Q2].[6]}
{[Time].[1997].[Q3].[7]}
{[Time].[1997].[Q3].[8]}
{[Time].[1997].[Q3].[9]}
{[Time].[1997].[Q4].[10]}
{[Time].[1997].[Q4].[11]}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Spokane].[Wildon Cameron]}
{[Customers].[USA].[WA].[Spokane].[Emily Barela]}
{[Customers].[USA].[WA].[Spokane].[Dauna Barton

Integration test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

mondrian.olap.Util
  • Branch Change: -.16%🔻
  • Complexity Change: -.21%🔻
  • Instruction Change: -.13%🔻
  • Line Change: -.28%🔻
mondrian.rolap.agg.SegmentBuilder
  • Branch Change: -3.23%🔻
  • Complexity Change: -4.30%🔻
  • Instruction Change: -1.25%🔻
  • Line Change: -1.18%🔻
mondrian.rolap.BatchLoader.BatchComparator
  • Branch Change: -6.25%🔻
  • Complexity Change: -8.33%🔻
  • Instruction Change: -5.41%🔻
  • Line Change: -3.70%🔻
mondrian.rolap.CellKey.Three
  • Branch Change: + 5.56%
  • Complexity Change: + 4.55%
mondrian.rolap.FastBatchingCellReader
  • Branch Change: -1.96%🔻
  • Complexity Change: -3.08%🔻
  • Instruction Change: -.42%🔻
  • Line Change: -1.18%🔻
mondrian.server.Execution
  • Branch Change: + 1.39%
  • Complexity Change: + 1.59%
  • Instruction Change: -.76%🔻
mondrian.util.StringKey
  • Branch Change: -8.33%🔻
  • Complexity Change: -9.09%🔻
  • Instruction Change: -2.00%🔻

License header violations

❗️ Copyright year is not the current year on mondrian/src/it/java/mondrian/rolap/NativeEvalVirtualCubeTest.java. Found 2016. Was expecting 2017

wingman-pentaho commented Feb 14, 2017

Build Completed

This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -fn -DrunITs=true -f pom.xml clean install && mvn -B -f pom.xml site

Cleanup Commands

mvn -B -f pom.xml build-helper:remove-project-artifact

Changed files

  mondrian/src/it/java/mondrian/rolap/NativeEvalVirtualCubeTest.java
  mondrian/src/it/java/mondrian/rolap/agg/SegmentBuilderTest.java

Newly Broken Tests:

mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderNoWildcards:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderThreeSegs:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithData:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithEmptySegmentBody:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {time_by_day.month_of_year=('2','3','4','5','6','7')}
    {time_by_day.quarter=('Q1','Q2','Q3')}
    {time_by_day.the_year=('1998')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[208c5162e6bb49ceb217eab3621f4fc0209f73265c291a3f8aa673aee775de81]
, *Segment
mondrian.rolap.NativeEvalVirtualCubeTest.testShouldUseCache:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
expected query [select
    `customer`.`gender` as `c0`
from
    `customer` as `customer`,
    `sales_fact_1997` as `sales_fact_1997`
where
    `sales_fact_1997`.`customer_id` = `customer`.`customer_id`
group by
    `customer`.`gender`
order by
    ISNULL(`c0`) ASC, `c0` ASC] did not occur
	at junit.framework.Assert.fail(Assert.java:47)
	at mondrian.rolap.BatchTestCase.assertQuerySqlOrNot(BatchTestCase.java:523)
	at mondrian.rolap.NativeEvalVirtualCubeTest.t

Newly Fixed Tests:

mondrian.test.CompoundSlicerTest.testBugMondrian899:

🔵 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{[Time].[1997].[Q1].[2]}
{[Time].[1997].[Q1].[3]}
{[Time].[1997].[Q2].[4]}
{[Time].[1997].[Q2].[5]}
{[Time].[1997].[Q2].[6]}
{[Time].[1997].[Q3].[7]}
{[Time].[1997].[Q3].[8]}
{[Time].[1997].[Q3].[9]}
{[Time].[1997].[Q4].[10]}
{[Time].[1997].[Q4].[11]}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Spokane].[Wildon Cameron]}
{[Customers].[USA].[WA].[Spokane].[Emily Barela]}
{[Customers].[USA].[WA].[Spokane].[Dauna Barton
mondrian.test.CompoundSlicerTest.testCompoundAggCalcMemberInSlicer1:

🔵 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Compound aggregated member should return same results with native filter on/off expected:<...Janis Strunk]}
{[Customers].[USA].[OR].[Albany].[L. Albert Wall]}
{[Customers].[USA].[OR].[Albany].[Norman Arnold]}
{[Customers].[USA].[OR].[Albany].[Pauline Kubitschek]}
{[Customers].[USA].[OR].[Albany].[Peggy Denton]}
{[Customers].[USA].[OR].[Albany].[Roslyn Jasper]}
{[Customers].[USA].[OR].[Albany].[Tina Heidi]}
{[Customers].[USA].[OR].[Albany].[Veronica Sulkind]}
{
mondrian.test.NamedSetTest.testHierarchizeNamedSetImmutable:

🔵 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Yakima].[Tracy Meyer], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[Vanessa Thompson], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[Velma Lykes], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[William Battaglia], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[W
mondrian.test.NamedSetTest.testNamedSetRangeInSlicerPrimed:

🔵 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{[Time].[1997].[Q1].[2]}
{[Time].[1997].[Q1].[3]}
{[Time].[1997].[Q2].[4]}
{[Time].[1997].[Q2].[5]}
{[Time].[1997].[Q2].[6]}
{[Time].[1997].[Q3].[7]}
{[Time].[1997].[Q3].[8]}
{[Time].[1997].[Q3].[9]}
{[Time].[1997].[Q4].[10]}
{[Time].[1997].[Q4].[11]}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Spokane].[Wildon Cameron]}
{[Customers].[USA].[WA].[Spokane].[Emily Barela]}
{[Customers].[USA].[WA].[Spokane].[Dauna Barton

Integration test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

mondrian.olap.Util
  • Branch Change: -.16%🔻
  • Complexity Change: -.21%🔻
  • Instruction Change: -.13%🔻
  • Line Change: -.28%🔻
mondrian.rolap.agg.SegmentBuilder
  • Branch Change: -3.23%🔻
  • Complexity Change: -4.30%🔻
  • Instruction Change: -1.25%🔻
  • Line Change: -1.18%🔻
mondrian.rolap.BatchLoader.BatchComparator
  • Branch Change: -6.25%🔻
  • Complexity Change: -8.33%🔻
  • Instruction Change: -5.41%🔻
  • Line Change: -3.70%🔻
mondrian.rolap.CellKey.Three
  • Branch Change: + 5.56%
  • Complexity Change: + 4.55%
mondrian.rolap.FastBatchingCellReader
  • Branch Change: -1.96%🔻
  • Complexity Change: -3.08%🔻
  • Instruction Change: -.42%🔻
  • Line Change: -1.18%🔻
mondrian.server.Execution
  • Branch Change: + 1.39%
  • Complexity Change: + 1.59%
  • Instruction Change: -.76%🔻
mondrian.util.StringKey
  • Branch Change: -8.33%🔻
  • Complexity Change: -9.09%🔻
  • Instruction Change: -2.00%🔻

License header violations

❗️ Copyright year is not the current year on mondrian/src/it/java/mondrian/rolap/NativeEvalVirtualCubeTest.java. Found 2016. Was expecting 2017

@wingman-pentaho

This comment has been minimized.

Show comment
Hide comment
@wingman-pentaho

wingman-pentaho Feb 14, 2017

Build Completed

This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -fn -DrunITs=true -f pom.xml clean install && mvn -B -f pom.xml site

Cleanup Commands

mvn -B -f pom.xml build-helper:remove-project-artifact

Changed files

  mondrian/src/it/java/mondrian/rolap/NativeEvalVirtualCubeTest.java
  mondrian/src/it/java/mondrian/rolap/agg/SegmentBuilderTest.java

Newly Broken Tests:

mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderNoWildcards:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderThreeSegs:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithData:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithEmptySegmentBody:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {time_by_day.month_of_year=('2','3','4','5','6','7')}
    {time_by_day.quarter=('Q1','Q2','Q3')}
    {time_by_day.the_year=('1998')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[208c5162e6bb49ceb217eab3621f4fc0209f73265c291a3f8aa673aee775de81]
, *Segment
mondrian.rolap.NativeEvalVirtualCubeTest.testShouldUseCache:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
expected query [select
    `customer`.`gender` as `c0`
from
    `customer` as `customer`,
    `sales_fact_1997` as `sales_fact_1997`
where
    `sales_fact_1997`.`customer_id` = `customer`.`customer_id`
group by
    `customer`.`gender`
order by
    ISNULL(`c0`) ASC, `c0` ASC] did not occur
	at junit.framework.Assert.fail(Assert.java:47)
	at mondrian.rolap.BatchTestCase.assertQuerySqlOrNot(BatchTestCase.java:523)
	at mondrian.rolap.NativeEvalVirtualCubeTest.t

Integration test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

mondrian.olap.fun.FunUtil
  • Branch Change: + .28%
  • Complexity Change: + .43%
  • Instruction Change: + .17%
  • Line Change: + .20%
mondrian.olap.ParameterImpl.new ParameterSlot() {...}
  • Complexity Change: -5.26%🔻
  • Instruction Change: -8.43%🔻
  • Line Change: -17.65%🔻
  • Method Change: -9.09%🔻
mondrian.olap.Util
  • Branch Change: -.16%🔻
  • Complexity Change: -.21%🔻
  • Instruction Change: -.02%🔻
  • Line Change: -.09%🔻
mondrian.rolap.agg.AggregationKey
  • Branch Change: + 3.57%
  • Complexity Change: + 4.17%
  • Instruction Change: + 1.15%
  • Line Change: + 2.38%
mondrian.rolap.agg.SegmentBuilder
  • Branch Change: -3.23%🔻
  • Complexity Change: -4.30%🔻
  • Instruction Change: -1.25%🔻
  • Line Change: -1.18%🔻
mondrian.rolap.agg.SegmentCacheManager.Actor
  • Instruction Change: -5.88%🔻
  • Line Change: -3.45%🔻
mondrian.rolap.BatchLoader.BatchComparator
  • Branch Change: -6.25%🔻
  • Complexity Change: -8.33%🔻
  • Instruction Change: -5.41%🔻
  • Line Change: -3.70%🔻
mondrian.server.Execution
  • Instruction Change: -.76%🔻

wingman-pentaho commented Feb 14, 2017

Build Completed

This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -fn -DrunITs=true -f pom.xml clean install && mvn -B -f pom.xml site

Cleanup Commands

mvn -B -f pom.xml build-helper:remove-project-artifact

Changed files

  mondrian/src/it/java/mondrian/rolap/NativeEvalVirtualCubeTest.java
  mondrian/src/it/java/mondrian/rolap/agg/SegmentBuilderTest.java

Newly Broken Tests:

mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderNoWildcards:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderThreeSegs:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithData:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {product_class.product_department=('Dairy')}
    {product_class.product_family=('Drink')}
    {time_by_day.the_year=('1997')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]
, *Segment Header
mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithEmptySegmentBody:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
SegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header
Schema:[FoodMart]
Checksum:[4079ae1a3e5190690712b752a45ee209]
Cube:[Sales]
Measure:[Unit Sales]
Axes:[
    {time_by_day.month_of_year=('2','3','4','5','6','7')}
    {time_by_day.quarter=('Q1','Q2','Q3')}
    {time_by_day.the_year=('1998')}]
Excluded Regions:[]
Compound Predicates:[]
ID:[208c5162e6bb49ceb217eab3621f4fc0209f73265c291a3f8aa673aee775de81]
, *Segment
mondrian.rolap.NativeEvalVirtualCubeTest.testShouldUseCache:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
expected query [select
    `customer`.`gender` as `c0`
from
    `customer` as `customer`,
    `sales_fact_1997` as `sales_fact_1997`
where
    `sales_fact_1997`.`customer_id` = `customer`.`customer_id`
group by
    `customer`.`gender`
order by
    ISNULL(`c0`) ASC, `c0` ASC] did not occur
	at junit.framework.Assert.fail(Assert.java:47)
	at mondrian.rolap.BatchTestCase.assertQuerySqlOrNot(BatchTestCase.java:523)
	at mondrian.rolap.NativeEvalVirtualCubeTest.t

Integration test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

mondrian.olap.fun.FunUtil
  • Branch Change: + .28%
  • Complexity Change: + .43%
  • Instruction Change: + .17%
  • Line Change: + .20%
mondrian.olap.ParameterImpl.new ParameterSlot() {...}
  • Complexity Change: -5.26%🔻
  • Instruction Change: -8.43%🔻
  • Line Change: -17.65%🔻
  • Method Change: -9.09%🔻
mondrian.olap.Util
  • Branch Change: -.16%🔻
  • Complexity Change: -.21%🔻
  • Instruction Change: -.02%🔻
  • Line Change: -.09%🔻
mondrian.rolap.agg.AggregationKey
  • Branch Change: + 3.57%
  • Complexity Change: + 4.17%
  • Instruction Change: + 1.15%
  • Line Change: + 2.38%
mondrian.rolap.agg.SegmentBuilder
  • Branch Change: -3.23%🔻
  • Complexity Change: -4.30%🔻
  • Instruction Change: -1.25%🔻
  • Line Change: -1.18%🔻
mondrian.rolap.agg.SegmentCacheManager.Actor
  • Instruction Change: -5.88%🔻
  • Line Change: -3.45%🔻
mondrian.rolap.BatchLoader.BatchComparator
  • Branch Change: -6.25%🔻
  • Complexity Change: -8.33%🔻
  • Instruction Change: -5.41%🔻
  • Line Change: -3.70%🔻
mondrian.server.Execution
  • Instruction Change: -.76%🔻
[TEST] Failing tests
Test was updated and now pass successfully
@wingman-pentaho

This comment has been minimized.

Show comment
Hide comment
@wingman-pentaho

wingman-pentaho Feb 15, 2017

Build Completed

This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -fn -DrunITs=true -f pom.xml clean install && mvn -B -f pom.xml site

Cleanup Commands

mvn -B -f pom.xml build-helper:remove-project-artifact

Changed files

  mondrian/src/it/java/mondrian/rolap/NativeEvalVirtualCubeTest.java

Newly Broken Tests:

mondrian.rolap.NativeEvalVirtualCubeTest.testShouldUseCache:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
expected query [select
    `customer`.`gender` as `c0`
from
    `customer` as `customer`,
    `sales_fact_1997` as `sales_fact_1997`
where
    `sales_fact_1997`.`customer_id` = `customer`.`customer_id`
group by
    `customer`.`gender`
order by
    ISNULL(`c0`) ASC, `c0` ASC] did not occur
	at junit.framework.Assert.fail(Assert.java:47)
	at mondrian.rolap.BatchTestCase.assertQuerySqlOrNot(BatchTestCase.java:523)
	at mondrian.rolap.NativeEvalVirtualCubeTest.t
mondrian.test.CompoundSlicerTest.testBugMondrian899:

🔴 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{[Time].[1997].[Q1].[2]}
{[Time].[1997].[Q1].[3]}
{[Time].[1997].[Q2].[4]}
{[Time].[1997].[Q2].[5]}
{[Time].[1997].[Q2].[6]}
{[Time].[1997].[Q3].[7]}
{[Time].[1997].[Q3].[8]}
{[Time].[1997].[Q3].[9]}
{[Time].[1997].[Q4].[10]}
{[Time].[1997].[Q4].[11]}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Spokane].[Wildon Cameron]}
{[Customers].[USA].[WA].[Spokane].[Emily Barela]}
{[Customers].[USA].[WA].[Spokane].[Dauna Barton
mondrian.test.CompoundSlicerTest.testCompoundAggCalcMemberInSlicer1:

🔴 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Compound aggregated member should return same results with native filter on/off expected:<...Janis Strunk]}
{[Customers].[USA].[OR].[Albany].[L. Albert Wall]}
{[Customers].[USA].[OR].[Albany].[Norman Arnold]}
{[Customers].[USA].[OR].[Albany].[Pauline Kubitschek]}
{[Customers].[USA].[OR].[Albany].[Peggy Denton]}
{[Customers].[USA].[OR].[Albany].[Roslyn Jasper]}
{[Customers].[USA].[OR].[Albany].[Tina Heidi]}
{[Customers].[USA].[OR].[Albany].[Veronica Sulkind]}
{
mondrian.test.NamedSetTest.testHierarchizeNamedSetImmutable:

🔴 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Yakima].[Tracy Meyer], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[Vanessa Thompson], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[Velma Lykes], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[William Battaglia], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[W
mondrian.test.NamedSetTest.testNamedSetRangeInSlicerPrimed:

🔴 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{[Time].[1997].[Q1].[2]}
{[Time].[1997].[Q1].[3]}
{[Time].[1997].[Q2].[4]}
{[Time].[1997].[Q2].[5]}
{[Time].[1997].[Q2].[6]}
{[Time].[1997].[Q3].[7]}
{[Time].[1997].[Q3].[8]}
{[Time].[1997].[Q3].[9]}
{[Time].[1997].[Q4].[10]}
{[Time].[1997].[Q4].[11]}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Spokane].[Wildon Cameron]}
{[Customers].[USA].[WA].[Spokane].[Emily Barela]}
{[Customers].[USA].[WA].[Spokane].[Dauna Barton

Newly Fixed Tests:

mondrian.rolap.agg.SegmentCacheTest.testConcurrentStatementRun:

🔵 java.util.concurrent.ExecutionException

java.util.concurrent.ExecutionException: java.lang.AssertionError
	at java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.util.concurrent.FutureTask.get(FutureTask.java:192)
	at mondrian.test.BasicQueryTest.testConcurrentStatementRun(BasicQueryTest.java:7861)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorI

Integration test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

mondrian.olap.ParameterImpl.new ParameterSlot() {...}
  • Complexity Change: + 5.26%
  • Instruction Change: + 8.43%
  • Line Change: + 17.65%
  • Method Change: + 9.09%
mondrian.rolap.RolapResultShepherd
  • Branch Change: -8.33%🔻
  • Complexity Change: -11.11%🔻
  • Instruction Change: -2.04%🔻
  • Line Change: -2.17%🔻
mondrian.server.MonitorImpl.Handler
  • Branch Change: + 2.27%
  • Complexity Change: + 1.85%
  • Instruction Change: + .42%
  • Line Change: + .50%
mondrian.server.StatementImpl
  • Branch Change: -21.43%🔻
  • Complexity Change: -12.50%🔻
  • Instruction Change: -9.49%🔻
  • Line Change: -9.09%🔻

wingman-pentaho commented Feb 15, 2017

Build Completed

This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -fn -DrunITs=true -f pom.xml clean install && mvn -B -f pom.xml site

Cleanup Commands

mvn -B -f pom.xml build-helper:remove-project-artifact

Changed files

  mondrian/src/it/java/mondrian/rolap/NativeEvalVirtualCubeTest.java

Newly Broken Tests:

mondrian.rolap.NativeEvalVirtualCubeTest.testShouldUseCache:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: 
expected query [select
    `customer`.`gender` as `c0`
from
    `customer` as `customer`,
    `sales_fact_1997` as `sales_fact_1997`
where
    `sales_fact_1997`.`customer_id` = `customer`.`customer_id`
group by
    `customer`.`gender`
order by
    ISNULL(`c0`) ASC, `c0` ASC] did not occur
	at junit.framework.Assert.fail(Assert.java:47)
	at mondrian.rolap.BatchTestCase.assertQuerySqlOrNot(BatchTestCase.java:523)
	at mondrian.rolap.NativeEvalVirtualCubeTest.t
mondrian.test.CompoundSlicerTest.testBugMondrian899:

🔴 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{[Time].[1997].[Q1].[2]}
{[Time].[1997].[Q1].[3]}
{[Time].[1997].[Q2].[4]}
{[Time].[1997].[Q2].[5]}
{[Time].[1997].[Q2].[6]}
{[Time].[1997].[Q3].[7]}
{[Time].[1997].[Q3].[8]}
{[Time].[1997].[Q3].[9]}
{[Time].[1997].[Q4].[10]}
{[Time].[1997].[Q4].[11]}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Spokane].[Wildon Cameron]}
{[Customers].[USA].[WA].[Spokane].[Emily Barela]}
{[Customers].[USA].[WA].[Spokane].[Dauna Barton
mondrian.test.CompoundSlicerTest.testCompoundAggCalcMemberInSlicer1:

🔴 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Compound aggregated member should return same results with native filter on/off expected:<...Janis Strunk]}
{[Customers].[USA].[OR].[Albany].[L. Albert Wall]}
{[Customers].[USA].[OR].[Albany].[Norman Arnold]}
{[Customers].[USA].[OR].[Albany].[Pauline Kubitschek]}
{[Customers].[USA].[OR].[Albany].[Peggy Denton]}
{[Customers].[USA].[OR].[Albany].[Roslyn Jasper]}
{[Customers].[USA].[OR].[Albany].[Tina Heidi]}
{[Customers].[USA].[OR].[Albany].[Veronica Sulkind]}
{
mondrian.test.NamedSetTest.testHierarchizeNamedSetImmutable:

🔴 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Yakima].[Tracy Meyer], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[Vanessa Thompson], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[Velma Lykes], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[William Battaglia], [Store].[USA].[WA].[Yakima].[Store 23]}
{[Customers].[USA].[WA].[Yakima].[W
mondrian.test.NamedSetTest.testNamedSetRangeInSlicerPrimed:

🔴 junit.framework.ComparisonFailure

junit.framework.ComparisonFailure: 
Expected:
Axis #0:
{[Time].[1997].[Q1].[2]}
{[Time].[1997].[Q1].[3]}
{[Time].[1997].[Q2].[4]}
{[Time].[1997].[Q2].[5]}
{[Time].[1997].[Q2].[6]}
{[Time].[1997].[Q3].[7]}
{[Time].[1997].[Q3].[8]}
{[Time].[1997].[Q3].[9]}
{[Time].[1997].[Q4].[10]}
{[Time].[1997].[Q4].[11]}
Axis #1:
{[Measures].[Unit Sales]}
Axis #2:
{[Customers].[USA].[WA].[Spokane].[Wildon Cameron]}
{[Customers].[USA].[WA].[Spokane].[Emily Barela]}
{[Customers].[USA].[WA].[Spokane].[Dauna Barton

Newly Fixed Tests:

mondrian.rolap.agg.SegmentCacheTest.testConcurrentStatementRun:

🔵 java.util.concurrent.ExecutionException

java.util.concurrent.ExecutionException: java.lang.AssertionError
	at java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.util.concurrent.FutureTask.get(FutureTask.java:192)
	at mondrian.test.BasicQueryTest.testConcurrentStatementRun(BasicQueryTest.java:7861)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorI

Integration test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

mondrian.olap.ParameterImpl.new ParameterSlot() {...}
  • Complexity Change: + 5.26%
  • Instruction Change: + 8.43%
  • Line Change: + 17.65%
  • Method Change: + 9.09%
mondrian.rolap.RolapResultShepherd
  • Branch Change: -8.33%🔻
  • Complexity Change: -11.11%🔻
  • Instruction Change: -2.04%🔻
  • Line Change: -2.17%🔻
mondrian.server.MonitorImpl.Handler
  • Branch Change: + 2.27%
  • Complexity Change: + 1.85%
  • Instruction Change: + .42%
  • Line Change: + .50%
mondrian.server.StatementImpl
  • Branch Change: -21.43%🔻
  • Complexity Change: -12.50%🔻
  • Instruction Change: -9.49%🔻
  • Line Change: -9.09%🔻
@Advent51

This comment has been minimized.

Show comment
Hide comment
@Advent51

Advent51 Feb 15, 2017

Contributor

That is strange that this fix brakes this test: mondrian.rolap.NativeEvalVirtualCubeTest.testShouldUseCache
Because it was broken on my local machines with Linux and Windows and was fixed by these changes.

Contributor

Advent51 commented Feb 15, 2017

That is strange that this fix brakes this test: mondrian.rolap.NativeEvalVirtualCubeTest.testShouldUseCache
Because it was broken on my local machines with Linux and Windows and was fixed by these changes.

@Advent51

This comment has been minimized.

Show comment
Hide comment
@Advent51

Advent51 Feb 15, 2017

Contributor

The problem is that we use embedded-MySQL which is version 5.6.14, but we should use 5.7.5 or newer one.
This test fails on MySQL server > 5.7.5 without my fix.
So, I think, it should't be merged before we update embedded-MySQL server.

Contributor

Advent51 commented Feb 15, 2017

The problem is that we use embedded-MySQL which is version 5.6.14, but we should use 5.7.5 or newer one.
This test fails on MySQL server > 5.7.5 without my fix.
So, I think, it should't be merged before we update embedded-MySQL server.

@Advent51 Advent51 closed this Feb 25, 2017

@Advent51 Advent51 deleted the Advent51:MONDRIAN-tests branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment