Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design review #114

Open
noisysocks opened this Issue Mar 26, 2019 · 6 comments

Comments

Projects
None yet
4 participants
@noisysocks
Copy link
Collaborator

noisysocks commented Mar 26, 2019

Let's get some feedback from the design team! Here's how TestPress looks currently.

Screen Light Dark
Docker not running docker not running light docker not running dark
No WordPress folder no wordpress folder light no wordpress folder dark
Getting ready getting ready light getting ready dark
Ready ready light ready dark
About about light about dark
Preferences preferences light preferences dark

@noisysocks noisysocks added this to the 1.0 milestone Mar 26, 2019

@noisysocks

This comment has been minimized.

Copy link
Collaborator Author

noisysocks commented Mar 27, 2019

My own notes:

  1. In Light mode, the icon button in upper right should be dark grey as it is in Gutenberg #116
  2. Link colour in Docker not running and No WordPress folder screens is too dark #117
  3. All buttons (e.g. Choose WordPress Folder, View site, View debug log) in dark mode should be dark #118
  4. Preferences screen should use WordPress components for buttons and tabs #119
  5. There's a thin translucent bar that appears between the TestPress window and the menu bar #120
  6. In light mode, the border underneath the header is too dark. It should match Gutenberg #123
@noisysocks

This comment has been minimized.

Copy link
Collaborator Author

noisysocks commented Mar 27, 2019

@pento: Want to add this to the next design meeting agenda? 🙂

@pento

This comment has been minimized.

Copy link
Owner

pento commented Mar 29, 2019

I spoke with @karmatosed, she's going to review it.

@noisysocks

This comment has been minimized.

Copy link
Collaborator Author

noisysocks commented Apr 1, 2019

I updated the screenshots now that #121 is merged.

@talldan

This comment has been minimized.

Copy link
Collaborator

talldan commented Apr 5, 2019

I have a PR (#146) open for the preferences issue.

@karmatosed

This comment has been minimized.

Copy link

karmatosed commented Apr 8, 2019

This feedback is based on the screenshots as running latest version seems not to reflect those. That in mind it really looks a high starting point.

Docker not running

  • In dark mode, this colour of the link I don't think will pass a contrast check. It's an excellent point to ensure this is checked.
  • I wonder if in dark mode the button couldn't change also?
  • Dark mode background seems 'blue/grey' over being a proper dark one. Is that just the screenshot or could it be increased in darkness?
  • While I understand the usage of the hand emoji, I am not sure it really helps here.
  • I think the text hierarchy needs looking at for example to ensure the text such as 'Docker is not running' stands out.
  • I also wonder if the amount of text is a good idea. How can that be distilled? It really needs to be instantly recognisable as to what state the screen is in. I'm not sure right now that's the case.

No WordPress folder

  • This really shows my above point of by scanning not really seeing what state you are in. It would be great to think of those that won't read all the text and how they can be informed.

Getting ready

  • I think bringing back here the traffic lights from the original work I did on TestPress could be a good idea. The tick is ok as a representation, but the dials are just too small and hard to work out what is going on in a dock position.

Ready

  • Do we need all 3 buttons? That's a lot of the same buttons at equal importance. I would love to see something like a primary action and then identify what the secondary ones are.

About

  • Similar to the waving hand, I am not sure about the use of the emoji here. I understand the intent but in this case, I think not using it would be better.

I'd be happy to do some sketches if you want, but I think most of my points can be made without. It's not that far off being able to release if these polishes are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.