router(dex): document safety assumptions in routing execution #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
commented
Apr 27, 2023
| // direction. | ||
| // + accumulated_effective_price != 0, because for each position | ||
| // we have p, q != 0. | ||
| unreachable!("current_value is nonzero") |
There was a problem hiding this comment.
@hdevalence you were right! it should be impossible to hit that branch, which is a relief. In the process of proving why i realized that a much more load bearing aspect of routing is in the end-to-end effective price calculation, so this is the next item on my TODO of double-checking assumptions. They are already marked as TODOs in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial goal of this PR was to prove (via a dust fill test) that during routing execution, it was possible to craft positions such that a saturating input would be zero. It turns out that this isn't possible, so this PR instead lays out why this isn't possible, and document various
SAFETYassumptions that the DEX engine makes.