Extract a penumbra-shielded-pool crate out of app,transaction.
#2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #2288. This is a proof-of-possibility for the architecture described in that issue. Now, the `penumbra-shielded-pool` crate is self-contained, with both the on-chain structures required to track the shielded pool, and the transaction actions needed to interact with it. In the future, a fair amount of functionality currently in the `penumbra-crypto` crate could now be lifted up into this crate, for instance the definitions of the spend and output proof statements.
hdevalence
force-pushed
the
split-app-shieldedpool
branch
from
33ddf46 to
236f352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2288. This is a proof-of-possibility for the architecture described in that issue. Now, the
penumbra-shielded-poolcrate is self-contained, with both the on-chain structures required to track the shielded pool, and the transaction actions needed to interact with it.In the future, a fair amount of functionality currently in the
penumbra-cryptocrate could now be lifted up into this crate, for instance the definitions of the spend and output proof statements.